You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/25 16:35:37 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #23096: Revise #23086, optimize some parameters and method naming.
RaigorJiang opened a new pull request, #23096:
URL: https://github.com/apache/shardingsphere/pull/23096
Revise #23086,
optimize some parameters and method naming.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #23096: Revise #23086, optimize some parameters and method naming.
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #23096:
URL: https://github.com/apache/shardingsphere/pull/23096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23096: Revise #23086, optimize some parameters and method naming.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23096:
URL: https://github.com/apache/shardingsphere/pull/23096#issuecomment-1364710579
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23096?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23096](https://codecov.io/gh/apache/shardingsphere/pull/23096?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51177f8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c502722672fb006f5b4832ef1ec449d4296af65f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c502722) will **decrease** coverage by `0.00%`.
> The diff coverage is `88.23%`.
```diff
@@ Coverage Diff @@
## master #23096 +/- ##
============================================
- Coverage 49.95% 49.94% -0.01%
Complexity 2422 2422
============================================
Files 4106 4106
Lines 57379 57371 -8
Branches 9066 9064 -2
============================================
- Hits 28662 28655 -7
Misses 26208 26208
+ Partials 2509 2508 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23096?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...andler/supporter/ShadowRuleStatementSupporter.java](https://codecov.io/gh/apache/shardingsphere/pull/23096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zdXBwb3J0ZXIvU2hhZG93UnVsZVN0YXRlbWVudFN1cHBvcnRlci5qYXZh) | `55.55% <ø> (ø)` | |
| [...ndler/update/CreateShadowRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQ3JlYXRlU2hhZG93UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `65.78% <76.47%> (ø)` | |
| [...ql/handler/checker/ShadowRuleStatementChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/23096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9jaGVja2VyL1NoYWRvd1J1bGVTdGF0ZW1lbnRDaGVja2VyLmphdmE=) | `92.30% <100.00%> (ø)` | |
| [...andler/converter/ShadowRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/23096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9jb252ZXJ0ZXIvU2hhZG93UnVsZVN0YXRlbWVudENvbnZlcnRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...andler/update/AlterShadowRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23096/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L2Rpc3RzcWwvaGFuZGxlci91cGRhdGUvQWx0ZXJTaGFkb3dSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `67.56% <100.00%> (-3.55%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org