[GitHub] [airflow] potiuk commented on pull request #33468: Replacing .gitignore with .gitkeep

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #33468:
URL: https://github.com/apache/airflow/pull/33468#issuecomment-1684861316

   Yeah. I am also with @uranusjr on that one. I think the ONLY benefit of using .gitkeep is that the name is explicit but all the other things are drawbacks. And having a directory which is called "empty" is quite an explicit naming already :).
   
   The one thing that I would change is to add comment inside the .gitignore file explaining the purpose of it. AND add '*' exclusion - which will have the effect that no-one will accidentally make the directory non-empty:
   
   ```
   # This file is here only to keep the empty directory managed by git
   # The purpose of this empty directory is ......
   *
   ```
   
   I think that is the best of all worlds:
   
   * you do not only use a .gitignore which is understood by git and all tools, 
   * you explicitly state the reason for the file being there
   * you also add protection agains accidentally making the directory non-empty
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org