You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by ca...@apache.org on 2016/04/19 15:14:29 UTC
svn commit: r1739927 - in /jackrabbit/oak/trunk/oak-run/src:
main/java/org/apache/jackrabbit/oak/plugins/tika/CSVFileGenerator.java
test/java/org/apache/jackrabbit/oak/plugins/tika/NodeStoreBinaryResourceProviderTest.java
Author: catholicon
Date: Tue Apr 19 13:14:29 2016
New Revision: 1739927
URL: http://svn.apache.org/viewvc?rev=1739927&view=rev
Log:
OAK-4237: NodeStoreBinaryResourceProviderTest#csvGenerator leaks temporary folder
Modified:
jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/CSVFileGenerator.java
jackrabbit/oak/trunk/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/tika/NodeStoreBinaryResourceProviderTest.java
Modified: jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/CSVFileGenerator.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/CSVFileGenerator.java?rev=1739927&r1=1739926&r2=1739927&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/CSVFileGenerator.java (original)
+++ jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/plugins/tika/CSVFileGenerator.java Tue Apr 19 13:14:29 2016
@@ -45,6 +45,7 @@ public class CSVFileGenerator {
try{
CSVPrinter printer = new CSVPrinter(Files.newWriter(outFile, Charsets.UTF_8),
CSVFileBinaryResourceProvider.FORMAT);
+ closer.register(printer);
for (BinaryResource br : binaries){
count++;
printer.printRecord(
Modified: jackrabbit/oak/trunk/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/tika/NodeStoreBinaryResourceProviderTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/tika/NodeStoreBinaryResourceProviderTest.java?rev=1739927&r1=1739926&r2=1739927&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/tika/NodeStoreBinaryResourceProviderTest.java (original)
+++ jackrabbit/oak/trunk/oak-run/src/test/java/org/apache/jackrabbit/oak/plugins/tika/NodeStoreBinaryResourceProviderTest.java Tue Apr 19 13:14:29 2016
@@ -86,6 +86,7 @@ public class NodeStoreBinaryResourceProv
CSVFileBinaryResourceProvider csvbrp = new CSVFileBinaryResourceProvider(csv, blobStore);
assertEquals(2, csvbrp.getBinaries("/").size());
+ csvbrp.close();
}
private NodeBuilder createFileNode(NodeBuilder base, String name, Blob content, String mimeType) {