You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/22 00:53:34 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36881: [SPARK-39484][SQL] Fix field name case sensitivity for struct type in V2WriteCommand.outputResolved

dongjoon-hyun commented on code in PR #36881:
URL: https://github.com/apache/spark/pull/36881#discussion_r903184211


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/V2WriteAnalysisSuite.scala:
##########
@@ -238,12 +238,28 @@ abstract class V2WriteAnalysisSuiteBase extends AnalysisTest {
   def byPosition(table: NamedRelation, query: LogicalPlan): LogicalPlan
 
   test("SPARK-33136: output resolved on complex types for V2 write commands") {

Review Comment:
   Thank you for pinging me.
   If you don't mind, please add a new test case instead of changing the existing test case, @edgarRd .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org