You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/02/04 13:12:46 UTC
[GitHub] msokolov opened a new pull request #562: Don't create a
LeafCollector when the Scorer for the leaf is null
msokolov opened a new pull request #562: Don't create a LeafCollector when the Scorer for the leaf is null
URL: https://github.com/apache/lucene-solr/pull/562
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [GitHub] msokolov opened a new pull request #562: Don't create a
LeafCollector when the Scorer for the leaf is null
Posted by Michael Sokolov <ms...@gmail.com>.
This PR proposes a small change a co-worker found. We can avoid creating a
leaf collectors for a leaf that matches no terms, which we can tell if the
scorer for it is null. One test was relying on the exact sequence of
collectors, enforcing that every one was created with no gaps in their
sequence, so this PR also cleans up that test, making the same assertions
without the need for that assumption.
-Mike Sokolov
On Mon, Feb 4, 2019 at 8:12 AM GitBox <gi...@apache.org> wrote:
> msokolov opened a new pull request #562: Don't create a LeafCollector when
> the Scorer for the leaf is null
> URL: https://github.com/apache/lucene-solr/pull/562
>
>
>
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>