You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/04/10 18:27:40 UTC
[GitHub] [netbeans] mbien opened a new pull request, #3953: version bump: require javac 18.
mbien opened a new pull request, #3953:
URL: https://github.com/apache/netbeans/pull/3953
NetBeans 14 expects javac 18 which means we have to increment the version for the javac checks too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #3953: version bump: require javac 18.
Posted by GitBox <gi...@apache.org>.
mbien merged PR #3953:
URL: https://github.com/apache/netbeans/pull/3953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3953: version bump: require javac 18.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #3953:
URL: https://github.com/apache/netbeans/pull/3953#issuecomment-1101885144
integrating this one. We can further improve those version checks for the next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3953: version bump: require javac 18.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #3953:
URL: https://github.com/apache/netbeans/pull/3953#issuecomment-1100245895
> Looks good, at least for a short term solution. A proper API for this, and linked to nb-javac updates in some way so the increment _can't_ be missed, might be useful in the future?
@neilcsmith-net I thought about this a bit.
It is essentially a runtime dependency check. Someone gonna have to bump the number no matter where it is taken from. We can't put it into the nb-javac module since the check has to work without it.
an assert could potentially check:
`assert ((NB_VERSION / 2 + 11) == REQUIRED_JAVAC_VERSION)`
which would fail if someone forgets the bump REQUIRED_JAVAC_VERSION in NB 16. However, where do we get `NB_VERSION` from? The release would have a system property for that, but a dev version doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists