[GitHub] betodealmeida commented on a change in pull request #5067: Allow multiple time shifts

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #5067: Allow multiple time shifts
URL: https://github.com/apache/incubator-superset/pull/5067#discussion_r190465245
 
 

 ##########
 File path: superset/assets/src/explore/controls.jsx
 ##########
 @@ -1575,11 +1575,20 @@ export const controls = {
   },
 
   time_compare: {
-    type: 'TextControl',
+    type: 'SelectControl',
+    multi: true,
 
 Review comment:
   Yeah, I remembered that as soon as I created the PR. Cool that there's a PR addressing it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org