[GitHub] spark pull request: [SPARK-15647] [SQL] Fix Boundary Cases in OptimizeCodege...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13392#discussion_r65184085
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
    @@ -937,8 +937,12 @@ object SimplifyConditionals extends Rule[LogicalPlan] with PredicateHelper {
      */
     case class OptimizeCodegen(conf: CatalystConf) extends Rule[LogicalPlan] {
       def apply(plan: LogicalPlan): LogicalPlan = plan transformAllExpressions {
    -    case e @ CaseWhen(branches, _) if branches.size < conf.maxCaseBranchesForCodegen =>
    -      e.toCodegen()
    +    case e: CaseWhen if canCodeGen(e) => e.toCodegen()
    --- End diff --
    
    Sure, let me fix it. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org