[GitHub] [incubator-doris] starocean999 commented on a diff in pull request #8745: [Enhancement] runtime filter may have negative effects in some primary-foreign key join

[GitBox <gi...@apache.org>]

starocean999 commented on code in PR #8745:
URL: https://github.com/apache/incubator-doris/pull/8745#discussion_r843691961


##########
fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilterGenerator.java:
##########
@@ -181,7 +203,7 @@ public static void generateRuntimeFilters(Analyzer analyzer, PlanNode plan) {
      * In the bottom-up traversal of the plan tree, the filters are assigned to destination
      * (scan) nodes. Filters that cannot be assigned to a scan node are discarded.
      */
-    private void generateFilters(PlanNode root) {
+    private void generateFilters(PlanNode root, HashSet<TupleId> tupleHasConjuncts) {

Review Comment:
   Done



##########
fe/fe-core/src/main/java/org/apache/doris/planner/RuntimeFilterGenerator.java:
##########
@@ -122,6 +122,24 @@ private RuntimeFilterGenerator(Analyzer analyzer) {
         bloomFilterSizeLimits = new FilterSizeLimits(sessionVariable);
     }
 
+    static class HasConjunctPredicate implements com.google.common.base.Predicate<PlanNode> {
+        @Override
+        public boolean apply(PlanNode arg) {
+            // for simplicity, skip join node( which contains more than 1 tuple id )
+            return arg.getTupleIds().size() == 1 && !arg.conjuncts.isEmpty();

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org