You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/21 03:06:11 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #13536: [Enhancement](runtime-filter) optimize for runtimefilter 64bit type hash function
BiteTheDDDDt opened a new pull request, #13536:
URL: https://github.com/apache/doris/pull/13536
# Proposed changes
1. change 64bit hash function from std::hash to direct_combine
2. modify some tpch query.
3. fix like function signature typo
<img width="1380" alt="图片" src="https://user-images.githubusercontent.com/7939630/197101949-6097adeb-9214-4c8a-824a-185972d562d7.png">
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt closed pull request #13536: [Enhancement](runtime-filter) optimize for runtimefilter 64bit type hash function
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt closed pull request #13536: [Enhancement](runtime-filter) optimize for runtimefilter 64bit type hash function
URL: https://github.com/apache/doris/pull/13536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #13536: [Enhancement](runtime-filter) optimize for runtimefilter 64bit type hash function
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #13536:
URL: https://github.com/apache/doris/pull/13536#discussion_r1001333560
##########
be/src/util/hash_util.hpp:
##########
@@ -45,11 +45,19 @@ namespace doris {
// Utility class to compute hash values.
class HashUtil {
public:
+ // like hash_combine but without hash
+ static inline uint32_t direct_combine(uint32_t x, uint32_t y) {
+ return x + 0x9e3779b9 + (y << 6) + (y >> 2);
+ }
+
template <typename T>
static uint32_t fixed_len_to_uint32(T value) {
if constexpr (sizeof(T) <= sizeof(uint32_t)) {
return value;
+ } else if constexpr (sizeof(T) == sizeof(uint64_t)) {
+ return direct_combine(((uint64_t)value << 32) >> 32, (uint64_t)value >> 32);
Review Comment:
using `value & (((uint32_t) 0) - 1)` to extract low bits is more efficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13536: [Enhancement](runtime-filter) optimize for runtimefilter 64bit type hash function
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13536:
URL: https://github.com/apache/doris/pull/13536#issuecomment-1286494802
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 39.09 seconds
load time: 574 seconds
storage size: 17154810559 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021135615_clickbench_pr_32338.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org