You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2020/06/10 15:25:12 UTC

[whimsy] branch master updated: Use library methods

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 201248d  Use library methods
201248d is described below

commit 201248da0f06808cba2271f33cbc6fe418f1db1c
Author: Sebb <se...@apache.org>
AuthorDate: Wed Jun 10 16:25:03 2020 +0100

    Use library methods
---
 www/board/agenda/views/actions/draft.json.rb | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/www/board/agenda/views/actions/draft.json.rb b/www/board/agenda/views/actions/draft.json.rb
index e68e464..74258f5 100644
--- a/www/board/agenda/views/actions/draft.json.rb
+++ b/www/board/agenda/views/actions/draft.json.rb
@@ -11,13 +11,11 @@ ASF::SVN.update minutes_file, @message, env, _ do |tmpdir, old_contents|
     old_contents
   else
     # retrieve the agenda on which these minutes are based
-    _.system ['svn', 'update',
-      ['--username', env.user, '--password', env.password],
-      File.join(tmpdir, File.basename(agenda_file))]
+    ASF::SVN.svn_('update', File.join(tmpdir, File.basename(agenda_file)), _, {env: env})
 
     # copy the agenda to the minutes (produces better diff)
-    _.system ['svn', 'cp', File.join(tmpdir, File.basename(@agenda)),
-      File.join(tmpdir, File.basename(minutes_file))]
+    ASF::SVN.svn_('cp',[File.join(tmpdir, File.basename(@agenda)), 
+                        File.join(tmpdir, File.basename(minutes_file))], _)
 
     @text
   end