You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/25 04:42:45 UTC
[GitHub] [incubator-eventmesh] DeepikaMarthandanTW opened a new pull request, #1829: [ISSUE #1720]Use stringBuilder instead of string in RedirectClientByIpPortHandler
DeepikaMarthandanTW opened a new pull request, #1829:
URL: https://github.com/apache/incubator-eventmesh/pull/1829
Fixes #1720.
### Motivation
In each iteration, the String is converted to a StringBuffer/StringBuilder, appended to, and converted back to a String. This can lead to a cost quadratic in the number of iterations, as the growing string is recopied in each iteration.
### Modifications
Converted string to string builder
### Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #1829: [ISSUE #1720]Use stringBuilder instead of string in RedirectClientByIpPortHandler
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #1829:
URL: https://github.com/apache/incubator-eventmesh/pull/1829#issuecomment-1290726083
@DeepikaMarthandanTW there's no file has been changed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #1829: [ISSUE #1720]Use stringBuilder instead of string in RedirectClientByIpPortHandler
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on PR #1829:
URL: https://github.com/apache/incubator-eventmesh/pull/1829#issuecomment-1291625776
> > @DeepikaMarthandanTW there's no file has been changed ?
>
> Yes, this issue has been fixed by @SunnyBoy-WYH
Ok, I'll close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed pull request #1829: [ISSUE #1720]Use stringBuilder instead of string in RedirectClientByIpPortHandler
Posted by GitBox <gi...@apache.org>.
xwm1992 closed pull request #1829: [ISSUE #1720]Use stringBuilder instead of string in RedirectClientByIpPortHandler
URL: https://github.com/apache/incubator-eventmesh/pull/1829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #1829: [ISSUE #1720]Use stringBuilder instead of string in RedirectClientByIpPortHandler
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #1829:
URL: https://github.com/apache/incubator-eventmesh/pull/1829#issuecomment-1290065709
@DeepikaMarthandanTW Please fix the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] DeepikaMarthandanTW commented on pull request #1829: [ISSUE #1720]Use stringBuilder instead of string in RedirectClientByIpPortHandler
Posted by GitBox <gi...@apache.org>.
DeepikaMarthandanTW commented on PR #1829:
URL: https://github.com/apache/incubator-eventmesh/pull/1829#issuecomment-1291469124
> @DeepikaMarthandanTW there's no file has been changed ?
Yes, this issue has been fixed by @SunnyBoy-WYH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org