[GitHub] [ignite] nizhikov commented on a diff in pull request #10511: IGNITE-18217 : Enable JMX metrics exporter by default

["nizhikov (via GitHub)" <gi...@apache.org>]

nizhikov commented on code in PR #10511:
URL: https://github.com/apache/ignite/pull/10511#discussion_r1099798399


##########
docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/ConfiguringMetrics.java:
##########
@@ -130,6 +133,19 @@ void jmxExporter() {
         Ignition.start(cfg).close();
     }
 
+    @Test
+    void disableDefaultJmxExporter() {
+
+        //tag::disable-default-jmx-exporter[]
+        IgniteConfiguration cfg = new IgniteConfiguration();
+
+        // Disable default JMX metrics exporter.
+        cfg.setMetricExporterSpi(new MetricExporterSpi[0]);

Review Comment:
   JMX exporter will be disabled with System property `IGNITE_MBEANS_DISABLED` or if some other exporter passed. Please, fix this test accordingly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org