[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #10997: dubbo metrics to springboot endpoints

[GitBox <gi...@apache.org>]

AlbumenJ commented on code in PR #10997:
URL: https://github.com/apache/dubbo/pull/10997#discussion_r1031089062


##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/DubboMetrics.java:
##########
@@ -0,0 +1,39 @@
+package org.apache.dubbo.metrics;

Review Comment:
   Please add ASF license header to this file



##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/DubboMetrics.java:
##########
@@ -0,0 +1,39 @@
+package org.apache.dubbo.metrics;
+
+import io.micrometer.core.instrument.Gauge;
+import io.micrometer.core.instrument.MeterRegistry;
+import io.micrometer.core.instrument.binder.MeterBinder;
+import org.apache.dubbo.common.utils.NamedThreadFactory;
+
+import java.util.HashSet;
+import java.util.Set;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * @author songxiaosheng

Review Comment:
   Remove this tag, pls



##########
dubbo-spring-boot/dubbo-spring-boot-actuator/src/main/java/org/apache/dubbo/spring/boot/actuate/autoconfigure/DubboMetricsAutoConfiguration.java:
##########
@@ -0,0 +1,29 @@
+package org.apache.dubbo.spring.boot.actuate.autoconfigure;
+
+import io.micrometer.core.instrument.MeterRegistry;
+import org.apache.dubbo.metrics.DubboMetrics;
+import org.apache.dubbo.spring.boot.actuate.mertics.DubboMetricsBinder;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnWebApplication;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+
+
+/**
+ * @author songxiaosheng

Review Comment:
   remove this tag pls



##########
dubbo-spring-boot/dubbo-spring-boot-actuator/src/main/java/org/apache/dubbo/spring/boot/actuate/autoconfigure/DubboMetricsAutoConfiguration.java:
##########
@@ -0,0 +1,29 @@
+package org.apache.dubbo.spring.boot.actuate.autoconfigure;

Review Comment:
   Please add ASF license header to this file



##########
dubbo-spring-boot/dubbo-spring-boot-actuator/src/main/java/org/apache/dubbo/spring/boot/actuate/mertics/DubboMetricsBinder.java:
##########
@@ -0,0 +1,31 @@
+package org.apache.dubbo.spring.boot.actuate.mertics;

Review Comment:
   Please add ASF license header to this file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org