You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/02/07 04:13:56 UTC
[GitHub] [netbeans] mbien commented on a diff in pull request #5219: Replaced usage of String.to[U/L]Case() with String.equalsIgnoreCase()
mbien commented on code in PR #5219:
URL: https://github.com/apache/netbeans/pull/5219#discussion_r1098155138
##########
webcommon/javascript.cdnjs/src/org/netbeans/modules/javascript/cdnjs/ui/SearchPanel.java:
##########
@@ -184,7 +184,7 @@ private void preSelectSearchedLibrary(Library[] libraries) {
int index = 0;
String term = lastSearchTerm == null ? "" : lastSearchTerm.toLowerCase(); // NOI18N
for (int i=0; i<libraries.length; i++) {
- if (libraries[i].getName().toLowerCase().equals(term)) {
+ if (libraries[i].getName().equalsIgnoreCase(term)) {
Review Comment:
`toLowerCase()` in L185 can be removed too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists