You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2014/10/22 17:29:13 UTC

Review Request 27042: Admin View: Provide identical cluster name validation in Manage

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27042/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.


Bugs: AMBARI-7902
    https://issues.apache.org/jira/browse/AMBARI-7902


Repository: ambari


Description
-------

Currently validation on Cluster Install Wizard -> Step0 and Manage Ambari -> Rename Cluster differs. For example on Installer -> Step0 we can use underscore in name, but during cluster rename it is forbidden.
These validations should match.


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html af09f57 

Diff: https://reviews.apache.org/r/27042/diff/


Testing
-------

tested manually


Thanks,

Andriy Babiichuk


Re: Review Request 27042: Admin View: Provide identical cluster name validation in Manage

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27042/#review57805
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 22, 2014, 3:29 після полудня, Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27042/
> -----------------------------------------------------------
> 
> (Updated Жов. 22, 2014, 3:29 після полудня)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7902
>     https://issues.apache.org/jira/browse/AMBARI-7902
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently validation on Cluster Install Wizard -> Step0 and Manage Ambari -> Rename Cluster differs. For example on Installer -> Step0 we can use underscore in name, but during cluster rename it is forbidden.
> These validations should match.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html af09f57 
> 
> Diff: https://reviews.apache.org/r/27042/diff/
> 
> 
> Testing
> -------
> 
> tested manually
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>


Re: Review Request 27042: Admin View: Provide identical cluster name validation in Manage

Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27042/#review57804
-----------------------------------------------------------

Ship it!


Ship It!

- Alexandr Antonenko


On Oct. 22, 2014, 3:29 p.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27042/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 3:29 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7902
>     https://issues.apache.org/jira/browse/AMBARI-7902
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently validation on Cluster Install Wizard -> Step0 and Manage Ambari -> Rename Cluster differs. For example on Installer -> Step0 we can use underscore in name, but during cluster rename it is forbidden.
> These validations should match.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/leftNavbar.html af09f57 
> 
> Diff: https://reviews.apache.org/r/27042/diff/
> 
> 
> Testing
> -------
> 
> tested manually
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>