You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/16 04:13:29 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31567: [SPARK-26138][SQL] Pushdown limit through InnerLike when condition is empty

HyukjinKwon commented on a change in pull request #31567:
URL: https://github.com/apache/spark/pull/31567#discussion_r576537936



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -546,10 +546,14 @@ object LimitPushDown extends Rule[LogicalPlan] {
     // on both sides if it is applied multiple times. Therefore:

Review comment:
       Shall we update the comments here too to describe the case when we push the limit with cross join?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org