You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2024/01/25 10:09:04 UTC

[PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

starocean999 opened a new pull request, #30378:
URL: https://github.com/apache/doris/pull/30378

   
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30378:
URL: https://github.com/apache/doris/pull/30378#issuecomment-1909885416

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38853 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 8c7e2843968cab73a3c65fa97bff100620539971, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17659	5238	5238	5238
   q2	2037	142	132	132
   q3	10636	1162	1163	1162
   q4	10219	743	819	743
   q5	7729	3171	3316	3171
   q6	197	121	123	121
   q7	871	496	483	483
   q8	9238	1948	1922	1922
   q9	7262	6378	6328	6328
   q10	8183	3021	3032	3021
   q11	402	213	224	213
   q12	351	190	195	190
   q13	17998	3377	3374	3374
   q14	247	211	218	211
   q15	538	535	501	501
   q16	463	391	380	380
   q17	952	522	501	501
   q18	7477	6976	6829	6829
   q19	1539	1353	1363	1353
   q20	577	311	293	293
   q21	2716	2394	2418	2394
   q22	344	296	293	293
   Total cold run time: 107635 ms
   Total hot run time: 38853 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5552	5282	5258	5258
   q2	322	224	216	216
   q3	3339	3264	3229	3229
   q4	2054	2087	2012	2012
   q5	6090	5946	5917	5917
   q6	202	116	120	116
   q7	2317	1843	1816	1816
   q8	3219	3372	3349	3349
   q9	8950	8760	8717	8717
   q10	3934	3813	3864	3813
   q11	562	467	447	447
   q12	794	620	605	605
   q13	16897	3176	3155	3155
   q14	274	253	270	253
   q15	560	503	510	503
   q16	524	454	470	454
   q17	1899	1836	1844	1836
   q18	9424	17081	9773	9773
   q19	26708	1615	1545	1545
   q20	4618	1935	1923	1923
   q21	14450	5380	5486	5380
   q22	964	531	539	531
   Total cold run time: 113653 ms
   Total hot run time: 60848 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #30378:
URL: https://github.com/apache/doris/pull/30378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30378:
URL: https://github.com/apache/doris/pull/30378#issuecomment-1909924434

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 8c7e2843968cab73a3c65fa97bff100620539971 with default session variables
   Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       13.6 seconds inserted 10000000 Rows, about 735K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30378:
URL: https://github.com/apache/doris/pull/30378#issuecomment-1909919845

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.96 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 8c7e2843968cab73a3c65fa97bff100620539971, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.02	0.03
   query3	0.23	0.05	0.05
   query4	1.70	0.07	0.07
   query5	0.54	0.53	0.52
   query6	1.32	0.63	0.67
   query7	0.02	0.02	0.01
   query8	0.04	0.03	0.03
   query9	0.54	0.52	0.49
   query10	0.56	0.57	0.56
   query11	0.11	0.09	0.09
   query12	0.10	0.10	0.08
   query13	0.60	0.61	0.60
   query14	0.77	0.83	0.81
   query15	0.79	0.79	0.76
   query16	0.37	0.36	0.37
   query17	0.99	1.04	1.03
   query18	0.24	0.24	0.24
   query19	1.87	1.79	1.74
   query20	0.02	0.01	0.01
   query21	15.40	0.57	0.56
   query22	2.98	2.83	2.21
   query23	17.11	0.90	0.85
   query24	2.27	0.98	0.64
   query25	0.36	0.25	0.15
   query26	0.52	0.15	0.13
   query27	0.06	0.05	0.05
   query28	12.61	0.77	0.76
   query29	12.56	3.11	3.20
   query30	0.52	0.50	0.48
   query31	2.78	0.34	0.36
   query32	3.38	0.49	0.50
   query33	3.20	3.28	3.22
   query34	16.19	4.32	4.28
   query35	4.36	4.30	4.25
   query36	1.10	1.07	1.08
   query37	0.07	0.05	0.05
   query38	0.03	0.02	0.02
   query39	0.02	0.01	0.02
   query40	0.17	0.13	0.14
   query41	0.06	0.01	0.02
   query42	0.02	0.01	0.01
   query43	0.03	0.02	0.01
   Total cold run time: 106.7 s
   Total hot run time: 30.96 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #30378:
URL: https://github.com/apache/doris/pull/30378#issuecomment-1909811288

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30378:
URL: https://github.com/apache/doris/pull/30378#issuecomment-1914107458

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30378:
URL: https://github.com/apache/doris/pull/30378#issuecomment-1914107403

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](nereids)window expression's window frame may lost in NormalizeToSlot [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30378:
URL: https://github.com/apache/doris/pull/30378#issuecomment-1909911498

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 186731 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 8c7e2843968cab73a3c65fa97bff100620539971, data reload: false
   
   query1	949	339	328	328
   query2	6555	2046	1918	1918
   query3	6699	207	202	202
   query4	33772	22239	22158	22158
   query5	4452	442	446	442
   query6	234	156	147	147
   query7	4605	269	254	254
   query8	225	168	177	168
   query9	8356	2610	2594	2594
   query10	429	232	237	232
   query11	16904	15461	15551	15461
   query12	116	68	66	66
   query13	1679	366	386	366
   query14	10568	7139	7092	7092
   query15	219	199	189	189
   query16	5784	259	250	250
   query17	948	477	478	477
   query18	1793	270	251	251
   query19	178	127	130	127
   query20	71	70	68	68
   query21	187	127	130	127
   query22	5048	4912	4830	4830
   query23	31756	30942	30733	30733
   query24	12571	2812	2819	2812
   query25	560	308	302	302
   query26	1768	143	139	139
   query27	3229	286	286	286
   query28	7244	1837	1818	1818
   query29	1777	634	617	617
   query30	280	133	140	133
   query31	949	767	766	766
   query32	82	48	44	44
   query33	694	204	207	204
   query34	1140	462	467	462
   query35	909	802	817	802
   query36	1285	1173	1229	1173
   query37	94	61	56	56
   query38	3346	3239	3242	3239
   query39	1308	1258	1265	1258
   query40	341	89	79	79
   query41	38	34	35	34
   query42	87	81	78	78
   query43	532	479	486	479
   query44	1064	696	697	696
   query45	186	176	171	171
   query46	1057	645	651	645
   query47	1656	1546	1554	1546
   query48	376	314	306	306
   query49	1168	289	283	283
   query50	680	311	308	308
   query51	5281	5184	5220	5184
   query52	96	79	79	79
   query53	318	252	256	252
   query54	236	171	177	171
   query55	83	72	73	72
   query56	175	161	163	161
   query57	988	932	934	932
   query58	193	146	154	146
   query59	2796	2744	2747	2744
   query60	206	184	178	178
   query61	81	80	80	80
   query62	627	366	367	366
   query63	282	256	252	252
   query64	6147	1786	1737	1737
   query65	3335	3272	3228	3228
   query66	1274	316	312	312
   query67	15661	14842	15208	14842
   query68	12305	536	517	517
   query69	589	304	289	289
   query70	1693	1498	1515	1498
   query71	10466	10199	10198	10198
   query72	4835	2834	2818	2818
   query73	2549	314	315	314
   query74	6896	6463	6402	6402
   query75	4937	2391	2291	2291
   query76	6688	1066	954	954
   query77	669	223	230	223
   query78	9135	8926	8710	8710
   query79	1077	503	491	491
   query80	590	337	313	313
   query81	449	203	204	203
   query82	208	80	76	76
   query83	138	115	115	115
   query84	274	69	66	66
   query85	1084	348	332	332
   query86	394	363	369	363
   query87	3467	3339	3343	3339
   query88	2953	2203	2186	2186
   query89	441	370	360	360
   query90	2003	192	182	182
   query91	160	122	120	120
   query92	57	44	46	44
   query93	1910	430	447	430
   query94	1258	158	156	156
   query95	505	454	449	449
   query96	627	316	311	311
   query97	4261	4150	4209	4150
   query98	192	185	183	183
   query99	1080	734	696	696
   Total cold run time: 307617 ms
   Total hot run time: 186731 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org