[GitHub] [incubator-superset] dpgaspar commented on pull request #10084: fix: Fixed bug for issue #9967 ( Hive date functions for group functions in charts )

[GitBox <gi...@apache.org>]

dpgaspar commented on pull request #10084:
URL: https://github.com/apache/incubator-superset/pull/10084#issuecomment-645413786


   No need to apologize, add tests here:
   https://github.com/apache/incubator-superset/blob/master/tests/db_engine_specs/hive_tests.py
   
   You can find examples for tests time grains here:
   https://github.com/apache/incubator-superset/blob/master/tests/db_engine_specs/postgres_tests.py#L53
   
   Thank you again for taking the time and effort!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org