You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/26 03:01:45 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2110: include/stdio.h: Fix build errors with CONFIG_LIBCXX=y

yamt commented on a change in pull request #2110:
URL: https://github.com/apache/incubator-nuttx/pull/2110#discussion_r511697715



##########
File path: include/stdio.h
##########
@@ -164,7 +164,7 @@ FAR char *gets(FAR char *s);
 FAR char *gets_s(FAR char *s, rsize_t n);
 void   rewind(FAR FILE *stream);
 
-#ifndef CONFIG_STDIO_DISABLE_BUFFERING
+#if !defined(CONFIG_STDIO_DISABLE_BUFFERING) || defined(CONFIG_LIBCXX)

Review comment:
       while i haven't investigated those usage deeply, i guess they are not "mandatory" parts of the library as helloxx/cxxtest are working for me.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org