You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Michael Brohl (Created) (JIRA)" <ji...@apache.org> on 2012/04/16 12:28:17 UTC
[jira] [Created] (OFBIZ-4810) createPartyContactMech: check for
infoString is done without using the contactMechTypeId
createPartyContactMech: check for infoString is done without using the contactMechTypeId
----------------------------------------------------------------------------------------
Key: OFBIZ-4810
URL: https://issues.apache.org/jira/browse/OFBIZ-4810
Project: OFBiz
Issue Type: Bug
Components: party
Affects Versions: SVN trunk
Reporter: Michael Brohl
Fix For: SVN trunk
The check for an existing infoString should use the contactMechTypeId.
I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4810) createPartyContactMech: check for
infoString is done without using the contactMechTypeId
Posted by "Sascha Rodekamp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp closed OFBIZ-4810.
----------------------------------
Resolution: Fixed
> createPartyContactMech: check for infoString is done without using the contactMechTypeId
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-4810
> URL: https://issues.apache.org/jira/browse/OFBIZ-4810
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4810_createPartyContactMech_check_infoString.patch
>
>
> The check for an existing infoString should use the contactMechTypeId.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-4810) createPartyContactMech: check for
infoString is done without using the contactMechTypeId
Posted by "Michael Brohl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Brohl updated OFBIZ-4810:
---------------------------------
Attachment: OFBIZ-4810_createPartyContactMech_check_infoString.patch
The patch.
> createPartyContactMech: check for infoString is done without using the contactMechTypeId
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-4810
> URL: https://issues.apache.org/jira/browse/OFBIZ-4810
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4810_createPartyContactMech_check_infoString.patch
>
>
> The check for an existing infoString should use the contactMechTypeId.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4810) createPartyContactMech: check for
infoString is done without using the contactMechTypeId
Posted by "Sascha Rodekamp (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sascha Rodekamp reassigned OFBIZ-4810:
--------------------------------------
Assignee: Sascha Rodekamp
> createPartyContactMech: check for infoString is done without using the contactMechTypeId
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-4810
> URL: https://issues.apache.org/jira/browse/OFBIZ-4810
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4810_createPartyContactMech_check_infoString.patch
>
>
> The check for an existing infoString should use the contactMechTypeId.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4810) createPartyContactMech: check for
infoString is done without using the contactMechTypeId
Posted by "Sascha Rodekamp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254653#comment-13254653 ]
Sascha Rodekamp commented on OFBIZ-4810:
----------------------------------------
Hi Michael, hi Jacques
i committed a modified version of the patch.
The part Jacques recommended is used by the condition list. The comments where made extendedly, i removed them.
In Trunk @Rev 1326567
Have a good day,
Sascha
> createPartyContactMech: check for infoString is done without using the contactMechTypeId
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-4810
> URL: https://issues.apache.org/jira/browse/OFBIZ-4810
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4810_createPartyContactMech_check_infoString.patch
>
>
> The check for an existing infoString should use the contactMechTypeId.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4810) createPartyContactMech: check for
infoString is done without using the contactMechTypeId
Posted by "Michael Brohl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254657#comment-13254657 ]
Michael Brohl commented on OFBIZ-4810:
--------------------------------------
Hi Jacques,
thanks you for your comment. You are right, the part I commented out is needed for the check.
Sascha already fixed it.
Thanks and regards,
Michael
> createPartyContactMech: check for infoString is done without using the contactMechTypeId
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-4810
> URL: https://issues.apache.org/jira/browse/OFBIZ-4810
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4810_createPartyContactMech_check_infoString.patch
>
>
> The check for an existing infoString should use the contactMechTypeId.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4810) createPartyContactMech: check for
infoString is done without using the contactMechTypeId
Posted by "Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254649#comment-13254649 ]
Jacques Le Roux commented on OFBIZ-4810:
----------------------------------------
Hi Michael,
You commented out
{code}
<entity-one entity-name="ContactMechType" value-field="contactMechType">
<field-map field-name="contactMechTypeId" from-field="partyAndContactMech.contactMechTypeId"/>
</entity-one>
{code}
But you left
{code}
<if-compare operator="equals" value="N" field="contactMechType.hasTable"/>
{code}
This is inconsistent. Did you intend to also remove the check upon contactMechType.hasTable (and forgot)? And then why to remove this check?
BTW I'd use rather if-compare-field, but that's very minor.
> createPartyContactMech: check for infoString is done without using the contactMechTypeId
> ----------------------------------------------------------------------------------------
>
> Key: OFBIZ-4810
> URL: https://issues.apache.org/jira/browse/OFBIZ-4810
> Project: OFBiz
> Issue Type: Bug
> Components: party
> Affects Versions: SVN trunk
> Reporter: Michael Brohl
> Assignee: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4810_createPartyContactMech_check_infoString.patch
>
>
> The check for an existing infoString should use the contactMechTypeId.
> I will provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira