[GitHub] [doris] weizuo93 commented on a diff in pull request #10711: [Feature] Add interface to check tablet segment lost

[GitBox <gi...@apache.org>]

weizuo93 commented on code in PR #10711:
URL: https://github.com/apache/doris/pull/10711#discussion_r926657603


##########
be/src/olap/tablet_manager.cpp:
##########
@@ -1333,4 +1333,30 @@ void TabletManager::get_all_tablets_storage_format(TCheckStorageFormatResult* re
     result->__isset.v2_tablets = true;
 }
 
+std::set<int64_t> TabletManager::check_all_tablet_segment(bool repair) {
+    std::set<int64_t> bad_tablets;
+    for (const auto& tablets_shard : _tablets_shards) {
+        std::shared_lock rdlock(tablets_shard.lock);

Review Comment:
   > read lock but modify tablet meta?
   
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org