[jira] [Updated] (SLING-4337) Sightly should only log errors from use providers if none of the use providers succeeded

["Radu Cotescu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Radu Cotescu updated SLING-4337:
--------------------------------
    Attachment: SLING-4337.patch

I attached the patch provided by [~justinedelson] ([^SLING-4337.patch]) after reviewing it:

* created an outcome initialised from an exception
* query all providers and if no provider returns success throw an exception with  the cause set to the exception thrown by the last provider that failed

> Sightly should only log errors from use providers if none of the use providers succeeded
> ----------------------------------------------------------------------------------------
>
>                 Key: SLING-4337
>                 URL: https://issues.apache.org/jira/browse/SLING-4337
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>            Reporter: Justin Edelson
>             Fix For: Scripting Sightly Engine 1.0.0
>
>         Attachments: SLING-4337.patch
>
>
> While iterating through the use providers, it is possible that one with fail and a later one will succeed. In this case, it doesn't make sense to log the failure from the first case. However, this is exactly what happens now with the PojoUseProvider which logs an error if a class can't be instantiated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)