[GitHub] [geode] mcmellawatt opened pull request #2600: GEODE-5857: Logging debug message if MBean is unregistered twice

["mcmellawatt (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2600 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2600: GEODE-5857: Logging debug message if MBean is unregistered twice

["mcmellawatt (GitHub)" <gi...@apache.org>]

Good point - I'm not sure that registerMBean is subject to the same race condition (multiple threads registering a given MBean), but for symmetry I see the argument that we should handle InstanceNotFoundExceptions there as well.  I will add that.

[ Full content available at: https://github.com/apache/geode/pull/2600 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2600: GEODE-5857: Logging debug message if MBean is unregistered twice

["jinmeiliao (GitHub)" <gi...@apache.org>]

Not sure if this is the right place to make the change. 

[ Full content available at: https://github.com/apache/geode/pull/2600 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2600: GEODE-5857: Logging debug message if MBean is unregistered twice

["jinmeiliao (GitHub)" <gi...@apache.org>]

Not sure if this is the right place to make the change.  If we make the change here, we then need to make similar change in registerMBean when InstanceAlreadyExsitsException is thrown. The original intent is that this InstanceNotFoundException is not supposed to happen here, if it is, then there is something wrong in the upstream.

[ Full content available at: https://github.com/apache/geode/pull/2600 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #2600: GEODE-5857: Handle JMX race conditions during registration and cleanup

["mcmellawatt (GitHub)" <gi...@apache.org>]

[ pull request closed by mcmellawatt ]

[ Full content available at: https://github.com/apache/geode/pull/2600 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #2600: GEODE-5857: Handle JMX race conditions during registration and cleanup

["mcmellawatt (GitHub)" <gi...@apache.org>]

Regarding the right place to make the change, after reading through the MBeanServer Javadocs, it appears that these exceptions are thrown either when an MBean is already registered when registering or unregistered when unregistering.  There is nothing that the callers would do with this information and it is essentially a no-op.  I think handling this exception as close to where it was thrown as possible is the right approach.

[ Full content available at: https://github.com/apache/geode/pull/2600 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org