You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "y616468159 (via GitHub)" <gi...@apache.org> on 2023/03/22 09:53:41 UTC
[GitHub] [ignite] y616468159 opened a new pull request, #10604: Fixed incorrect comments for 'getBatchSize' method
y616468159 opened a new pull request, #10604:
URL: https://github.com/apache/ignite/pull/10604
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1700618653
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10604)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] y616468159 closed pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "y616468159 (via GitHub)" <gi...@apache.org>.
y616468159 closed pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
URL: https://github.com/apache/ignite/pull/10604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1698606057
@y616468159, can you please also fix javadoc for `GridNearTxLocal#suspend` and `GridCacheSharedContext#suspendTx`? They contain notes about optimistic transactions too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10604: Fixed incorrect comments for 'getBatchSize' method
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1646515860
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10604)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1698402042
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10604)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] y616468159 commented on pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "y616468159 (via GitHub)" <gi...@apache.org>.
y616468159 commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1702022271
@alex-plekhanov Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10604: Fixed incorrect comments for 'getBatchSize' method
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1646517126
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10604)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1698785109
@y616468159, it's better to use this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] sonarcloud[bot] commented on pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1698774277
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=10604)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=10604&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=10604&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=10604&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] luchnikovbsk commented on a diff in pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "luchnikovbsk (via GitHub)" <gi...@apache.org>.
luchnikovbsk commented on code in PR #10604:
URL: https://github.com/apache/ignite/pull/10604#discussion_r1307029468
##########
modules/core/src/main/java/org/apache/ignite/transactions/Transaction.java:
##########
@@ -277,14 +277,14 @@ public interface Transaction extends AutoCloseable, IgniteAsyncSupport {
public IgniteFuture<Void> rollbackAsync() throws IgniteException;
/**
- * Resume a transaction if it was previously suspended. <strong>Supported only for optimistic transactions.</strong>
+ * Resume a transaction if it was previously suspended. <strong>Now, It supports pessimistic transactions and optimistic transactions.</strong>
Review Comment:
Might be better to delete - <strong>Supported only for optimistic transactions.</strong>?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] luchnikovbsk commented on a diff in pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "luchnikovbsk (via GitHub)" <gi...@apache.org>.
luchnikovbsk commented on code in PR #10604:
URL: https://github.com/apache/ignite/pull/10604#discussion_r1307031110
##########
modules/core/src/main/java/org/apache/ignite/transactions/Transaction.java:
##########
@@ -277,14 +277,14 @@ public interface Transaction extends AutoCloseable, IgniteAsyncSupport {
public IgniteFuture<Void> rollbackAsync() throws IgniteException;
/**
- * Resume a transaction if it was previously suspended. <strong>Supported only for optimistic transactions.</strong>
+ * Resume a transaction if it was previously suspended. <strong>Now, It supports pessimistic transactions and optimistic transactions.</strong>
*
* @throws IgniteException If resume failed.
*/
public void resume() throws IgniteException;
/**
- * Suspends a transaction. It could be resumed later. <strong>Supported only for optimistic transactions.</strong>
+ * Suspends a transaction. It could be resumed later. <strong>Now, It supports pessimistic transactions and optimistic transactions.</strong>
Review Comment:
Same as the previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] y616468159 commented on a diff in pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "y616468159 (via GitHub)" <gi...@apache.org>.
y616468159 commented on code in PR #10604:
URL: https://github.com/apache/ignite/pull/10604#discussion_r1309552681
##########
modules/core/src/main/java/org/apache/ignite/transactions/Transaction.java:
##########
@@ -277,14 +277,14 @@ public interface Transaction extends AutoCloseable, IgniteAsyncSupport {
public IgniteFuture<Void> rollbackAsync() throws IgniteException;
/**
- * Resume a transaction if it was previously suspended. <strong>Supported only for optimistic transactions.</strong>
+ * Resume a transaction if it was previously suspended. <strong>Now, It supports pessimistic transactions and optimistic transactions.</strong>
*
* @throws IgniteException If resume failed.
*/
public void resume() throws IgniteException;
/**
- * Suspends a transaction. It could be resumed later. <strong>Supported only for optimistic transactions.</strong>
+ * Suspends a transaction. It could be resumed later. <strong>Now, It supports pessimistic transactions and optimistic transactions.</strong>
Review Comment:
Also, I submitted a [JIRA question](https://issues.apache.org/jira/browse/IGNITE-20024), but no one communicated with me. Should I submit the modifications directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] y616468159 commented on pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "y616468159 (via GitHub)" <gi...@apache.org>.
y616468159 commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1698752133
> @y616468159，您可以同时修复`GridNearTxLocal#suspend`和的javadoc`GridCacheSharedContext#suspendTx`吗？它们还包含有关乐观交易的注释。
Yes, I can solve it! May I submit it directly in the current pull request or do I need to create a separate pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
URL: https://github.com/apache/ignite/pull/10604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] y616468159 commented on pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "y616468159 (via GitHub)" <gi...@apache.org>.
y616468159 commented on PR #10604:
URL: https://github.com/apache/ignite/pull/10604#issuecomment-1698750360
> @y616468159，您能同时修复`GridNearTxLocal#suspend`和 的javadoc`GridCacheSharedContext#suspendTx`吗？它们还包含有关乐观交易的注释。
> @y616468159，您可以同时修复`GridNearTxLocal#suspend`和的javadoc`GridCacheSharedContext#suspendTx`吗？它们还包含有关乐观交易的注释。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] y616468159 commented on a diff in pull request #10604: IGNITE-18330 Fix javadoc in Transaction#resume(), Transaction#suspend, CacheJdbcPojoStoreFactory#getBatchSize
Posted by "y616468159 (via GitHub)" <gi...@apache.org>.
y616468159 commented on code in PR #10604:
URL: https://github.com/apache/ignite/pull/10604#discussion_r1309535455
##########
modules/core/src/main/java/org/apache/ignite/transactions/Transaction.java:
##########
@@ -277,14 +277,14 @@ public interface Transaction extends AutoCloseable, IgniteAsyncSupport {
public IgniteFuture<Void> rollbackAsync() throws IgniteException;
/**
- * Resume a transaction if it was previously suspended. <strong>Supported only for optimistic transactions.</strong>
+ * Resume a transaction if it was previously suspended. <strong>Now, It supports pessimistic transactions and optimistic transactions.</strong>
*
* @throws IgniteException If resume failed.
*/
public void resume() throws IgniteException;
/**
- * Suspends a transaction. It could be resumed later. <strong>Supported only for optimistic transactions.</strong>
+ * Suspends a transaction. It could be resumed later. <strong>Now, It supports pessimistic transactions and optimistic transactions.</strong>
Review Comment:
Thank you for your guidance. Now I have resubmitted according to your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org