You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Nick Burch <ni...@torchbox.com> on 2007/09/26 12:06:09 UTC

Re: svn commit: r579546 - /poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDateUtil.java

On Wed, 26 Sep 2007, yegor@apache.org wrote:
> commented out a failing test until we find the reason.

The odd thing is that test passes on my computer (I'd already disabled the 
test that did fail before committing). So I'm not quite sure why things 
are failing on gump :/

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

TestHSSFDateUtil.java Patch

Posted by Pavel Krupets <pk...@yahoo.com>.
Hello,

Sorry CALENDAR months had invalid values (constants). Fixed and uncommented
test method.

With regards,
Pavel Krupets

Re[3]: svn commit: r579546 - /poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDateUtil.java

Posted by Yegor Kozlov <ye...@dinom.ru>.
I confirmed that it fails because of the recent changes in
HSSFFormulaEvaluator.

 Here is the list of the failing tests:
 
        new GenericFormulaTestCase("D487").genericTest();     //NullPointerException
        new GenericFormulaTestCase("D488").genericTest();       //EmptyStackException
        new GenericFormulaTestCase("D768").genericTest();       //EmptyStackException
        new GenericFormulaTestCase("D788").genericTest();       //EmptyStackException
        new GenericFormulaTestCase("D1304").genericTest();      //AssertionFailedError: Formula: SUM(E15:E17) @ 1303:6 expected:<0> but was:<5>
        new GenericFormulaTestCase("D1400").genericTest();     //EmptyStackException

 After rollback to an earlier version (-r576504) all the tests but
 D487 pass. I'm pretty sure after the full rollback it will pass also.

 So, how soon will it be fixed? If we don't get the fix tonight I
 suggest rolling it back to what we had 2 days ago.

 Pavel, any ideas?
        
 Yegor
        
> Well, now Gump complains on
> org.apache.poi.hssf.record.formula.functions.TestEverything.

> It's hard to diagnosis. The ant's output just says "BUILD FAILED".
> If I insert try/catch in GenericFormulaTestCase I can see that the
> following tests fail:

> new GenericFormulaTestCase("D487")
> new GenericFormulaTestCase("D488")
> new GenericFormulaTestCase("D768")
> new GenericFormulaTestCase("D788")
> new GenericFormulaTestCase("D1304")
> new GenericFormulaTestCase("D1400")

> Could it be because of the recent changes in HSSFFormulaEvaluator?
> Any thoughts?

> Yegor

>> On Wed, 26 Sep 2007, yegor@apache.org wrote:
>>> commented out a failing test until we find the reason.

>> The odd thing is that test passes on my computer (I'd already disabled the
>> test that did fail before committing). So I'm not quite sure why things
>> are failing on gump :/

>> Nick

>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org


> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

Re[2]: svn commit: r579546 - /poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFDateUtil.java

Posted by Yegor Kozlov <ye...@dinom.ru>.
Well, now Gump complains on org.apache.poi.hssf.record.formula.functions.TestEverything.

It's hard to diagnosis. The ant's output just says "BUILD FAILED".
If I insert try/catch in GenericFormulaTestCase I can see that the
following tests fail:

new GenericFormulaTestCase("D487")
new GenericFormulaTestCase("D488")
new GenericFormulaTestCase("D768")
new GenericFormulaTestCase("D788")
new GenericFormulaTestCase("D1304")
new GenericFormulaTestCase("D1400")

Could it be because of the recent changes in HSSFFormulaEvaluator?
Any thoughts?

Yegor

> On Wed, 26 Sep 2007, yegor@apache.org wrote:
>> commented out a failing test until we find the reason.

> The odd thing is that test passes on my computer (I'd already disabled the
> test that did fail before committing). So I'm not quite sure why things
> are failing on gump :/

> Nick

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org