You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/30 16:01:20 UTC

[GitHub] [airflow] subkanthi commented on a change in pull request #20590: Fix mypy errors in amazon aws transfer

subkanthi commented on a change in pull request #20590:
URL: https://github.com/apache/airflow/pull/20590#discussion_r776784323



##########
File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py
##########
@@ -132,12 +132,13 @@ def execute(self, context: 'Context'):
                 if self.ftp_filenames == '*':
                     files = list_dir
                 else:
-                    files = list(filter(lambda file: self.ftp_filenames in file, list_dir))
+                    ftp_filename: str = self.ftp_filenames
+                    files = list(filter(lambda f: ftp_filename in f, list_dir))

Review comment:
       couldnt find a better way to fix this, the line 136 is fine since there is a isinstance(str) check in 125, but mypy still complains.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org