[GitHub] [lucene] dweiss commented on a diff in pull request #11937: reland: 11925 javac options

[GitBox <gi...@apache.org>]

dweiss commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023550549


##########
gradle/hacks/turbocharge-jvm-opts.gradle:
##########
@@ -38,4 +39,20 @@ allprojects {
 
         jvmArgs += vmOpts
     }
-}
\ No newline at end of file
+
+    // Tweak javac to not be too resource-hungry.
+    // This applies to any JVM when javac runs forked (e.g. error-prone)
+    // Avoiding the fork entirely is best.
+    tasks.withType(JavaCompile) { JavaCompile task ->
+        if (task.path == ":lucene:core:compileMain19Java") {

Review Comment:
   Hmm... perhaps this should be somehow fixed where the alt jvm hack is - it'd be consistent here (and everywhere). It looks like gradle prefixes jvm options with -J internally, which we don't do?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org