You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/11 01:42:05 UTC

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #4752: [Improvement-4751][API] Improvement the duration field modify the display to a time-based minute-second format (e.g. 1d 10h 20m 1s)

CalvinKirs commented on a change in pull request #4752:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4752#discussion_r574204693



##########
File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessInstance.java
##########
@@ -202,7 +202,7 @@
      * @return
      */
     @TableField(exist = false)
-    private Long duration;
+    private String duration;

Review comment:
       hi, should we separate this and create different beans?
   It is not recommended to use one for DO, DTO, and VO.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org