You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/11 19:25:32 UTC
[GitHub] [lucene-solr] madrob opened a new pull request #1860: LUCENE-9488 Update release process to work with gradle
madrob opened a new pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860
https://issues.apache.org/jira/browse/LUCENE-9488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#issuecomment-692044500
Should the smokeTester be in the scope of this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#issuecomment-692233865
@janhoy I'm trying to run this, but the `create_stable_branch` step tries to create a new `branch_8x` for me, I think that logic needs some updating, but I'm not completely sure what needs to change. If you're able, please take a look, otherwise I'll skip that part and come back to it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r488176182
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
You can definere a variable like we do for rename command, that used `gradlew.bat` for win?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r487405745
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r487405745
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r487405745
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob merged pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r488766685
##########
File path: lucene/version.properties
##########
@@ -0,0 +1,10 @@
+# This file contains some version properties as used by various build files.
Review comment:
Please remove that file, it wont be used.
If release scripts need to edit the version number after a release, <root>/build.gradle is your friend. Theres also a version.base and that's the source of information.
https://github.com/apache/lucene-solr/blob/master/build.gradle#L38
There is a reason why this file was removed, so dont restore it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#issuecomment-692761861
Sure, all progress is good progress
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#issuecomment-692272683
There may be bugs related to major release since that has never been done with the wizard. I guess it should have created a `branch_9x`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r488771433
##########
File path: dev-tools/scripts/buildAndPushRelease.py
##########
@@ -108,37 +107,26 @@ def prepare(root, version, gpgKeyID, gpgPassword):
print(' Check DOAP files')
checkDOAPfiles(version)
- print(' ant -Dtests.badapples=false clean validate documentation-lint test')
- run('ant -Dtests.badapples=false clean validate documentation-lint test')
+ print(' ./gradlew -Dtests.badapples=false clean check')
+ run('./gradlew -Dtests.badapples=false clean check')
open('rev.txt', mode='wb').write(rev.encode('UTF-8'))
- print(' lucene prepare-release')
- os.chdir('lucene')
- cmd = 'ant -Dversion=%s' % version
+ print(' prepare-release')
+ cmd = './gradlew -Dversion=%s clean' % version
Review comment:
This must be `-Dversion.release=%s`, as gradle has some reserved meaning of `version`.
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -1059,7 +1056,7 @@ groups:
logfile: checkout-release-tag.log
tee: true
- !Command
- cmd: ant documentation -Dversion={{ release_version }}
+ cmd: "{{ gradle_cmd }} documentation -Dversion={{ release_version }}"
Review comment:
This must be `-Dversion.release=%s`, as gradle has some reserved meaning of `version`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
uschindler commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r488766685
##########
File path: lucene/version.properties
##########
@@ -0,0 +1,10 @@
+# This file contains some version properties as used by various build files.
Review comment:
Ülease remove that file, it wont be used.
If release scripts need to edit the version number after a release, <root>/build.gradle is your friend. Theres also a version.base and that's the source of information.
https://github.com/apache/lucene-solr/blob/master/build.gradle#L38
There is a reason why this file was removed, so dont restore it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] janhoy commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r487405745
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Will the `./` syntax work on Windows?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r488273580
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
Works great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#issuecomment-692357517
@janhoy This isn't actually ready yet, but I'd like to merge what I have so far. The reason is that the way the script pulls from upstream to prep the RC, I kind of need changes on the actual master branch in order to proceed with further testing without resorting to some super hacky tricks locally to make it think that my fork is the place to pull from.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #1860: LUCENE-9488 Update release process to work with gradle
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r487623979
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -411,7 +410,7 @@ groups:
cmd: git pull
stdout: true
- !Command
- cmd: ant clean precommit
+ cmd: ./gradlew clean check -x test
Review comment:
It works in PowerShell but not Command Prompt. I don't know how important this distinction is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org