[GitHub] [druid] cryptoe commented on a diff in pull request #14350: Add logs for deleting files using storage connector

["cryptoe (via GitHub)" <gi...@apache.org>]

cryptoe commented on code in PR #14350:
URL: https://github.com/apache/druid/pull/14350#discussion_r1209776402


##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/S3StorageConnector.java:
##########
@@ -329,11 +335,14 @@ private void deleteKeys(List<DeleteObjectsRequest.KeyVersion> versions) throws I
   public void deleteRecursively(String dirName) throws IOException
   {
     try {
+      final String fullPath = objectPath(dirName);
+      log.debug("Deleting directory at bucket: %s, path: %s", config.getBucket(), fullPath);
+

Review Comment:
   Please push these logging line to the s3Utils class so that other callers also benefit from it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org