You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2019/05/02 01:17:19 UTC
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13212
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
Brings in HADOOP-14747 (S3AInputStream to implement CanUnbuffer) which
is necessary for IMPALA-8428. The file handle cache calls `unbuffer()`
on a file handle before returning it to the cache. The call to
`unbuffer()` releases any resources that the file handle is holding onto
(in the S3A case the underlying S3ObjectInputStream is closed). Without
this fix an impalad would quickly crash as every cached file handle
would be holding onto a HTTP connection.
Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/13212/1
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4133/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 01:23:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
Brings in HADOOP-14747 (S3AInputStream to implement CanUnbuffer) which
is necessary for IMPALA-8428. The file handle cache calls `unbuffer()`
on a file handle before returning it to the cache. The call to
`unbuffer()` releases any resources that the file handle is holding onto
(in the S3A case the underlying S3ObjectInputStream is closed). Without
this fix an impalad would quickly crash as every cached file handle
would be holding onto a HTTP connection.
Testing:
* Ran an exhaustive build
Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Reviewed-on: http://gerrit.cloudera.org:8080/13212
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 5
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 15:05:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 01:23:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 4:
> Patch Set 4:
>
> Looks like https://gerrit.cloudera.org/c/13213/ is bumping to a higher version than this one, perhaps we should abandon this one?
Oh wait, scratch that, this is the CDH version, that one is the CDP version. Ignore me!
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 02 May 2019 16:40:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 4:
Looks like https://gerrit.cloudera.org/c/13213/ is bumping to a higher version than this one, perhaps we should abandon this one?
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 02 May 2019 16:40:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4138/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 15:05:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
Brings in HADOOP-14747 (S3AInputStream to implement CanUnbuffer) which
is necessary for IMPALA-8428. The file handle cache calls `unbuffer()`
on a file handle before returning it to the cache. The call to
`unbuffer()` releases any resources that the file handle is holding onto
(in the S3A case the underlying S3ObjectInputStream is closed). Without
this fix an impalad would quickly crash as every cached file handle
would be holding onto a HTTP connection.
Testing:
* Ran an exhaustive build
Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/13212/2
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 3: Code-Review+2
> Patch Set 3:
>
> Not really sure why the gerrit-verify job failed. It says the rat-check-ub1604 job failed because of:
>
> 02:51:23 + trap 'rm -rf /home/ubuntu/tmp.TnRrh5SO0C' EXIT
> 02:51:23 + sudo apt-get -qq update
> 02:51:28 + sudo apt-get -qq --yes install git python
> 02:51:28 E: Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)
> 02:51:28 E: Unable to lock the administration directory (/var/lib/dpkg/), is another process using it?
> 02:51:28 + rm -rf /home/ubuntu/tmp.TnRrh5SO0C
> 02:51:29 Build step 'Execute shell' marked build as failure
> 02:51:29 Set build name.
> 02:51:29 New build name is '#7261 refs/changes/12/13212/3'
> 02:51:32 Finished: FAILURE
>
> Perhaps we got unlucky and another process was trying to run apt-get as well, but does not seem related to this patch.
Yeah, I saw that too. Will retry.
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 15:05:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 01:22:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3030/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 02:06:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4133/
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 06:36:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 02 May 2019 20:13:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8428: Bump CDH BUILD NUMBER to 1055188.
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13212 )
Change subject: IMPALA-8428: Bump CDH_BUILD_NUMBER to 1055188.
......................................................................
Patch Set 3:
Not really sure why the gerrit-verify job failed. It says the rat-check-ub1604 job failed because of:
02:51:23 + trap 'rm -rf /home/ubuntu/tmp.TnRrh5SO0C' EXIT
02:51:23 + sudo apt-get -qq update
02:51:28 + sudo apt-get -qq --yes install git python
02:51:28 E: Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)
02:51:28 E: Unable to lock the administration directory (/var/lib/dpkg/), is another process using it?
02:51:28 + rm -rf /home/ubuntu/tmp.TnRrh5SO0C
02:51:29 Build step 'Execute shell' marked build as failure
02:51:29 Set build name.
02:51:29 New build name is '#7261 refs/changes/12/13212/3'
02:51:32 Finished: FAILURE
Perhaps we got unlucky and another process was trying to run apt-get as well, but does not seem related to this patch.
--
To view, visit http://gerrit.cloudera.org:8080/13212
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b2169afff9af41d6f31312feb74ee362ecacf5
Gerrit-Change-Number: 13212
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 May 2019 14:31:03 +0000
Gerrit-HasComments: No