You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jason Rosenberg (JIRA)" <ji...@apache.org> on 2009/04/01 07:22:51 UTC

[jira] Commented: (WICKET-2085) DateTimeField.HoursValidator relies on deprecated NumberValidator

    [ https://issues.apache.org/jira/browse/WICKET-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694389#action_12694389 ] 

Jason Rosenberg commented on WICKET-2085:
-----------------------------------------

Just wanted to point out, that I ran into this issue (using 1.4 rc2), and got this cryptic feedback from a validation error on the hours field:

Could not locate error message for component: TextField@inputForm:manualOverrideUntil:hours and error: [ValidationError message=[null], keys=[NumberValidator.range, DateTimeField$HoursValidator], variables=[[minimum=0],[maximum=24]]]. Tried keys: NumberValidator.range, DateTimeField$HoursValidator.

I assume the short-term fix is to add a resource for the NumberValidator.range to my project.  Seems there should be a default work-around that actually works...

Jason

> DateTimeField.HoursValidator relies on deprecated NumberValidator
> -----------------------------------------------------------------
>
>                 Key: WICKET-2085
>                 URL: https://issues.apache.org/jira/browse/WICKET-2085
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-datetime
>    Affects Versions: 1.4-RC3
>            Reporter: Ian Bacher
>            Priority: Minor
>         Attachments: patch.diff
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> NumberValidator is being deprecated in favor of RangeValidator and the DateTimeField.HoursValidator was already emulating RangeValidator. This patch makes HoursValidator a subclass of RangeValidator with no change to the API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.