[jira] [Commented] (SOLR-12337) Remove QueryWrapperFilter

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498581#comment-16498581 ] 

ASF subversion and git services commented on SOLR-12337:
--------------------------------------------------------

Commit 4888adf08a70c25b4d931a2bdfdcfe3979ba3936 in lucene-solr's branch refs/heads/master from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4888adf ]

SOLR-12337: Remove the obsolete QueryWrapperFilter


> Remove QueryWrapperFilter
> -------------------------
>
>                 Key: SOLR-12337
>                 URL: https://issues.apache.org/jira/browse/SOLR-12337
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: SOLR-12337.patch, SOLR-12337.patch
>
>
> QueryWrapperFilter has not been needed ever since Filter was changed to extend Query -- LUCENE-1518.  It was retained because there was at least one place in Lucene that had a Filter/Query distinction, but it was forgotten when Filter moved to Solr.  It contains some code that creates a temporary IndexSearcher but forgets to null out the cache on it, and so QueryWrapperFilter can add non-trivial overhead.  We should simply remove it altogether.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org