Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

["Will-Lo (via GitHub)" <gi...@apache.org>]

Will-Lo commented on code in PR #3937:
URL: https://github.com/apache/gobblin/pull/3937#discussion_r1583251020


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -97,35 +97,13 @@ public abstract class BaseFlowToJobSpecCompiler implements SpecCompiler {
 
   private Optional<UserQuotaManager> userQuotaManager;
 
-  public BaseFlowToJobSpecCompiler(Config config){
-    this(config,true);
-  }
-
-  public BaseFlowToJobSpecCompiler(Config config, boolean instrumentationEnabled){
-    this(config, Optional.<Logger>absent(),  true);
-  }
-
-  public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log){
-    this(config, log,true);
-  }
-
-  public BaseFlowToJobSpecCompiler(Config config, Optional<Logger> log, boolean instrumentationEnabled){
-    this.log = log.isPresent() ? log.get() : LoggerFactory.getLogger(getClass());
-    if (instrumentationEnabled) {

Review Comment:
   Is the intention here to remove the use of this variable for checking if instrumentation is enabled? It's still used widely in GaaS modules so there should be justification



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org