You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/02/11 09:06:57 UTC
[GitHub] [ignite] tledkov-gridgain opened a new pull request #9819: IGNITE-14916 Calcite. RuntimeHashIndex scan must filter result by predicate
tledkov-gridgain opened a new pull request #9819:
URL: https://github.com/apache/ignite/pull/9819
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain commented on pull request #9819: IGNITE-14916 Calcite. RuntimeHashIndex scan must filter result by predicate
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain commented on pull request #9819:
URL: https://github.com/apache/ignite/pull/9819#issuecomment-1036131715
@alex-plekhanov , thanks for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9819: IGNITE-14916 Calcite. RuntimeHashIndex scan must filter result by predicate
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #9819:
URL: https://github.com/apache/ignite/pull/9819#discussion_r804487654
##########
File path: modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/HashIndexSpoolExecutionTest.java
##########
@@ -115,6 +115,7 @@ public void testIndexSpool() throws Exception {
ctx,
rowType,
ImmutableBitSet.of(0),
+ null,
Review comment:
Let's use `testFilter` and add some test case with filtering, for example, something like:
```
new GridTuple3(
(Predicate<Object[]>)(r -> ((int)r[2]) == 0),
new Object[] {size / 2 + 1, null, null},
1
)
```
##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/RuntimeHashIndex.java
##########
@@ -108,11 +109,15 @@ private GroupKey key(Row r) {
/** Search row. */
private final Supplier<Row> searchRow;
+ /** Row filter. */
+ private final Predicate<Row> filter;
+
/**
* @param searchRow Search row.
*/
- IndexScan(Supplier<Row> searchRow) {
+ IndexScan(Supplier<Row> searchRow, Predicate<Row> filter) {
Review comment:
Let's mark filter as `@Nullable` (here and up in the stack)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #9819: IGNITE-14916 Calcite. RuntimeHashIndex scan must filter result by predicate
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #9819:
URL: https://github.com/apache/ignite/pull/9819#discussion_r804582447
##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/RuntimeHashIndex.java
##########
@@ -108,11 +109,15 @@ private GroupKey key(Row r) {
/** Search row. */
private final Supplier<Row> searchRow;
+ /** Row filter. */
+ private final Predicate<Row> filter;
+
/**
* @param searchRow Search row.
*/
- IndexScan(Supplier<Row> searchRow) {
+ IndexScan(Supplier<Row> searchRow, Predicate<Row> filter) {
Review comment:
Still not nullable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain merged pull request #9819: IGNITE-14916 Calcite. RuntimeHashIndex scan must filter result by predicate
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain merged pull request #9819:
URL: https://github.com/apache/ignite/pull/9819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] tledkov-gridgain merged pull request #9819: IGNITE-14916 Calcite. RuntimeHashIndex scan must filter result by predicate
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain merged pull request #9819:
URL: https://github.com/apache/ignite/pull/9819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org