You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by dl...@apache.org on 2001/07/18 11:16:19 UTC
cvs commit: jakarta-velocity/src/java/org/apache/velocity/test/provider TestProvider.java
dlr 01/07/18 02:16:19
Modified: src/java/org/apache/velocity/test/provider TestProvider.java
Log:
An array of minor optimizations to make our tests run faster.
Revision Changes Path
1.18 +23 -25 jakarta-velocity/src/java/org/apache/velocity/test/provider/TestProvider.java
Index: TestProvider.java
===================================================================
RCS file: /home/cvs/jakarta-velocity/src/java/org/apache/velocity/test/provider/TestProvider.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -u -r1.17 -r1.18
--- TestProvider.java 2001/06/29 23:39:03 1.17
+++ TestProvider.java 2001/07/18 09:16:19 1.18
@@ -61,8 +61,8 @@
* are fed into the context that is set before the AST
* is traversed and dynamic content generated.
*
- * @author <a href="mailto:jvanzyl@periapt.com">Jason van Zyl</a>
- * @version $Id: TestProvider.java,v 1.17 2001/06/29 23:39:03 geirm Exp $
+ * @author <a href="mailto:jvanzyl@apache.org">Jason van Zyl</a>
+ * @version $Id: TestProvider.java,v 1.18 2001/07/18 09:16:19 dlr Exp $
*/
public class TestProvider
{
@@ -240,36 +240,40 @@
return "result of objectArrayMethod";
}
- public String concat(Object[] o)
+ public String concat(Object[] strings)
{
- String result = "";
+ StringBuffer result = new StringBuffer();
- for (int i = 0; i < o.length; i++)
- result += (String) o[i] + " ";
+ for (int i = 0; i < strings.length; i++)
+ {
+ result.append((String) strings[i]).append(' ');
+ }
- return result;
+ return result.toString();
}
- public String concat( List o)
+ public String concat(List strings)
{
- String result = "";
+ StringBuffer result = new StringBuffer();
- for (int i = 0; i < o.size(); i++)
- result += (String) o.get(i) + " ";
+ for (int i = 0; i < strings.size(); i++)
+ {
+ result.append((String) strings.get(i)).append(' ');
+ }
- return result;
+ return result.toString();
}
- public String objConcat( List list)
+ public String objConcat(List objects)
{
- String result = "";
- Object o;
- for (int i = 0; i < list.size(); i++)
+ StringBuffer result = new StringBuffer();
+
+ for (int i = 0; i < objects.size(); i++)
{
- o = list.get(i);
- result += o.toString() + " ";
+ result.append(objects.get(i)).append(' ');
}
- return result;
+
+ return result.toString();
}
public String parse(String a, Object o, String c, String d)
@@ -387,10 +391,4 @@
{
throw new Exception("From getThrow()");
}
-
}
-
-
-
-
-