You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/27 17:16:37 UTC

[GitHub] [helix] rabashizade commented on pull request #1715: Change MessageQueueMonitor from static to dynamic metric

rabashizade commented on pull request #1715:
URL: https://github.com/apache/helix/pull/1715#issuecomment-827773745


   > LGTM. Could you please double check where the monitor gets used, including in the test, and make sure there won't be any regression.
   
   Thanks for the comment. I double-checked, the monitor is only used in the HelixTaskExecutor class, and is only instantiated in 3 other places (MockHelixTaskExecutor, TestP2PNoDuplicatedMessage, and DefaultMessagingService) none of which resulted in any issues with changing the metric.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org