You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/12/21 18:40:13 UTC
[PR] refactor: Removes the DASHBOARD_FILTERS_EXPERIMENTAL feature flag [superset]
michael-s-molina opened a new pull request, #26330:
URL: https://github.com/apache/superset/pull/26330
### SUMMARY
As part of the [4.0 approved initiatives](https://github.com/orgs/apache/projects/292/views/1), this PR removes the `DASHBOARD_FILTERS_EXPERIMENTAL` feature flag and the associated `GroupByFilterPlugin`.
### TESTING INSTRUCTIONS
CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor: Removes the DASHBOARD_FILTERS_EXPERIMENTAL feature flag [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26330:
URL: https://github.com/apache/superset/pull/26330#issuecomment-1866781421
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/26330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`5e85f5c`)](https://app.codecov.io/gh/apache/superset/commit/5e85f5c81f66b2da6fa11d9112216004f35170c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.18% compared to head [(`00caaae`)](https://app.codecov.io/gh/apache/superset/pull/26330?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 58.93%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #26330 +/- ##
===========================================
- Coverage 69.18% 58.93% -10.26%
===========================================
Files 1945 1945
Lines 75971 75970 -1
Branches 8467 8467
===========================================
- Hits 52559 44770 -7789
- Misses 21225 29013 +7788
Partials 2187 2187
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/26330/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/26330/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/26330/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/26330/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/26330/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.63% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/26330/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `61.53% <ø> (-21.33%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/26330/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/26330/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.79% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/26330?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor: Removes the DASHBOARD_FILTERS_EXPERIMENTAL feature flag [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #26330:
URL: https://github.com/apache/superset/pull/26330#issuecomment-1866789016
@michael-s-molina was there broad agreement to remove the groupby Filter? The reason I ask is because I don't think it's been marked as deprecated, and I believe some orgs may be using it. Ping @amitmiran137 @simcha90 @cccs-jc @cccs-rc for heads up and any concerns if you missed the discussion (not sure if this is relevant for your orgs or not).
While I'm sure this should rather be brought up in the town hall, I think there's good use cases for the groupby filter, and cleaning it up and adding full support to the ECharts plugin package could be a fairly low hanging fruit, and one that I could potentially take on if this is still deemed relevant for other users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor: Removes the DASHBOARD_FILTERS_EXPERIMENTAL feature flag [superset]
Posted by "cccs-rc (via GitHub)" <gi...@apache.org>.
cccs-rc commented on PR #26330:
URL: https://github.com/apache/superset/pull/26330#issuecomment-1866960603
> @michael-s-molina was there broad agreement to remove the groupby Filter? The reason I ask is because I don't think it's been marked as deprecated, and I believe some orgs may be using it. Ping @amitmiran137 @simcha90 @cccs-jc @cccs-rc for heads up and any concerns if you missed the discussion (not sure if this is relevant for your orgs or not).
>
> While I'm sure this should rather be brought up in the town hall, I think there's good use cases for the groupby filter, and cleaning it up and adding full support to the ECharts plugin package could be a fairly low hanging fruit, and one that I could potentially take on if this is still deemed relevant for other users.
Thanks for the heads up @villebro! We're not currently using the Group By filters, but admittedly that's only because I hadn't spotted the feature flag before. I agree there are good use cases for it that aren't entirely covered by the drill by feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor: Removes the DASHBOARD_FILTERS_EXPERIMENTAL feature flag [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #26330:
URL: https://github.com/apache/superset/pull/26330#issuecomment-1866800616
@villebro It's a good question. We can submit a [specific proposal](https://github.com/orgs/apache/projects/292/views/1?pane=issue&itemId=48229848) for lazy consensus for removing the `GroupByFilterPlugin` and see if someone is using it and is able to support it. If not, then let's remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor: Removes the DASHBOARD_FILTERS_EXPERIMENTAL feature flag [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #26330:
URL: https://github.com/apache/superset/pull/26330#issuecomment-1866805714
The drill by feature provides a similar functionality as the `GroupByFilterPlugin` and for that reason we may choose to remove the plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] refactor: Removes the deprecated DASHBOARD_FILTERS_EXPERIMENTAL feature flag [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #26330:
URL: https://github.com/apache/superset/pull/26330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org