You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/05/12 18:24:31 UTC

[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #20261: [v1.x] ONNX: fix error handling when op is not registered

samskalicky commented on a change in pull request #20261:
URL: https://github.com/apache/incubator-mxnet/pull/20261#discussion_r631299671



##########
File path: python/mxnet/onnx/mx2onnx/_export_onnx.py
##########
@@ -91,15 +91,22 @@ def convert_layer(node, **kwargs):
 
         op = str(node["op"])
         opset_version = kwargs.get("opset_version", onnx_opset_version())
+        if opset_version < 12:
+            logging.warning('Your ONNX op set version is %s, '  % str(opset_version) +
+                            'which is lower than then lowest tested op set (12), please consider '

Review comment:
       is there some variable we can use to print the op set version instead of hard coding "12" in this message? its likely we may forget to update it later...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org