You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "cryptoe (via GitHub)" <gi...@apache.org> on 2023/11/02 17:39:06 UTC

[PR] Doc fixes for query from deep storage and MSQ (druid)

cryptoe opened a new pull request, #15313:
URL: https://github.com/apache/druid/pull/15313

   Minor updates to the documentation. 
   * Added pre requisites. 
   * Removed a known issue in MSQ since its not longer valid. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Doc fixes for query from deep storage and MSQ (druid)

Posted by "317brian (via GitHub)" <gi...@apache.org>.
317brian commented on code in PR #15313:
URL: https://github.com/apache/druid/pull/15313#discussion_r1380619985


##########
docs/querying/query-from-deep-storage.md:
##########
@@ -24,6 +24,9 @@ title: "Query from deep storage"
 
 Druid can query segments that are only stored in deep storage. Running a query from deep storage is slower than running queries from segments that are loaded on Historical processes, but it's a great tool for data that you either access infrequently or where the low latency results that typical Druid queries provide is not necessary. Queries from deep storage can increase the surface area of data available to query without requiring you to scale your Historical processes to accommodate more segments.
 
+## Pre-requisites
+* Please enable the multi-stage query extension before you begin. See [enable multi-stage query](../multi-stage-query/index.md#load-the-extension) for more information.

Review Comment:
   ```suggestion
   
   Query from deep storage requires the Multi-stage query (MSQ) task engine. Load the extension for it if you don't already have it enabled before you begin. See [enable MSQ](../multi-stage-query/index.md#load-the-extension) for more information.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Doc fixes for query from deep storage and MSQ (druid)

Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #15313:
URL: https://github.com/apache/druid/pull/15313


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Doc fixes for query from deep storage and MSQ (druid)

Posted by "317brian (via GitHub)" <gi...@apache.org>.
317brian commented on code in PR #15313:
URL: https://github.com/apache/druid/pull/15313#discussion_r1380621397


##########
docs/tutorials/tutorial-query-deep-storage.md:
##########
@@ -31,6 +31,8 @@ To run the queries in this tutorial, replace `ROUTER:PORT` with the location of
 
 For more general information, see [Query from deep storage](../querying/query-from-deep-storage.md).
 
+If you are trying this feature on an existing cluster, make sure query from deep storage [pre-requisites](../querying/query-from-deep-storage.md#pre-requisites) are met.

Review Comment:
   ```suggestion
   If you are trying this feature on an existing cluster, make sure query from deep storage [pre-requisites](../querying/query-from-deep-storage.md#prerequisites) are met.
   ```



##########
docs/querying/query-from-deep-storage.md:
##########
@@ -24,6 +24,9 @@ title: "Query from deep storage"
 
 Druid can query segments that are only stored in deep storage. Running a query from deep storage is slower than running queries from segments that are loaded on Historical processes, but it's a great tool for data that you either access infrequently or where the low latency results that typical Druid queries provide is not necessary. Queries from deep storage can increase the surface area of data available to query without requiring you to scale your Historical processes to accommodate more segments.
 
+## Pre-requisites

Review Comment:
   ```suggestion
   ## Prerequisites
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] Doc fixes for query from deep storage and MSQ (druid)

Posted by "317brian (via GitHub)" <gi...@apache.org>.
317brian commented on code in PR #15313:
URL: https://github.com/apache/druid/pull/15313#discussion_r1380621397


##########
docs/tutorials/tutorial-query-deep-storage.md:
##########
@@ -31,6 +31,8 @@ To run the queries in this tutorial, replace `ROUTER:PORT` with the location of
 
 For more general information, see [Query from deep storage](../querying/query-from-deep-storage.md).
 
+If you are trying this feature on an existing cluster, make sure query from deep storage [pre-requisites](../querying/query-from-deep-storage.md#pre-requisites) are met.

Review Comment:
   ```suggestion
   If you are trying this feature on an existing cluster, make sure query from deep storage [prerequisites](../querying/query-from-deep-storage.md#prerequisites) are met.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org