[GitHub] [pinot] navina commented on a diff in pull request #8509: Fix table creation bug for invalid realtime consumer props

[GitBox <gi...@apache.org>]

navina commented on code in PR #8509:
URL: https://github.com/apache/pinot/pull/8509#discussion_r847837277


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1384,7 +1384,7 @@ public List<String> getSchemaNames() {
   public void addTable(TableConfig tableConfig)
       throws IOException {
     String tableNameWithType = tableConfig.getTableName();
-    if (getTableConfig(tableNameWithType) != null) {
+    if (hasTable(tableNameWithType)) {
       throw new TableAlreadyExistsException("Table " + tableNameWithType + " already exists");

Review Comment:
   nit: I think the error message can be more detailed - 
   ```
   Table already exists in helix ??
   ```
   Or maybe add a debug line in there. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org