[jira] [Commented] (NIFI-5228) Allow user to choose whether or not to add File Attributes as FlowFile Attributes when using FetchFile

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484444#comment-16484444 ] 

ASF GitHub Bot commented on NIFI-5228:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2733

    NIFI-5228: Allow user to choose whether or not to add File Attributes as FlowFile Attributes when using FetchFile

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5228

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2733.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2733
    
----
commit 336d44ba34fad702cb69393be1ea96111b3d9577
Author: Mark Payne <ma...@...>
Date:   2018-05-22T16:13:49Z

    NIFI-5191: Revert "NIFI-4631: Use java.nio.file.Files in ListFile to improve performance"
    
    This reverts commit 758e44682f994b76fcb9fec900eece2061be7f07.

commit 00e2a6174ccba7e36a3bc60082216a122dd47588
Author: Mark Payne <ma...@...>
Date:   2018-05-22T19:04:59Z

    NIFI-5228: Make the storing of file attributes as FlowFile attributes optional for ListFile

----


> Allow user to choose whether or not to add File Attributes as FlowFile Attributes when using FetchFile
> ------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-5228
>                 URL: https://issues.apache.org/jira/browse/NIFI-5228
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.7.0
>
>
> The FetchFile processor adds several FlowFIle attributes such as the file's owner, last accessed time, creation time, etc. While these certainly can be useful pieces of information and do serve a purpose, they can be expensive to determine in some configurations. In my use case, I have an Azure File Store mounted to an Ubuntu system with CIFS using SMB 3.0. The remote directory that I am listing has 7,000-8,000 files and takes about 3 minutes to perform the listing with ListFile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)