You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/09 18:15:20 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3396: HDDS-6719. Verify build from source release tarball in CI
adoroszlai opened a new pull request, #3396:
URL: https://github.com/apache/ozone/pull/3396
## What changes were proposed in this pull request?
Change _compile_ check to work against source tarball created by _build_ check to ensure the contents of the tarball can be compiled. The goal is to catch changes that become a problem only at release time.
https://issues.apache.org/jira/browse/HDDS-6719
## How was this patch tested?
Regular CI:
1. _build_ check uploaded source tarball: https://github.com/adoroszlai/hadoop-ozone/runs/6355813051#step:8:19
2. _compile_ check used it instead of git repo: https://github.com/adoroszlai/hadoop-ozone/runs/6356144283#step:3:1
3. checks using binary tarball still work fine: https://github.com/adoroszlai/hadoop-ozone/runs/6356144521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #3396: HDDS-6719. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3396:
URL: https://github.com/apache/ozone/pull/3396#discussion_r868562987
##########
dev-support/ci/selective_ci_checks.sh:
##########
@@ -521,12 +521,14 @@ function set_outputs() {
initialization::ga_output basic-checks \
"$(initialization::parameters_to_json ${BASIC_CHECKS})"
- if [[ "${compose_tests_needed}" == "true" ]] || [[ "${kubernetes_tests_needed}" == "true" ]]; then
+ : ${compile_needed:=false}
Review Comment:
I am not sure I follow this,
##########
dev-support/ci/selective_ci_checks.sh:
##########
@@ -521,12 +521,14 @@ function set_outputs() {
initialization::ga_output basic-checks \
"$(initialization::parameters_to_json ${BASIC_CHECKS})"
- if [[ "${compose_tests_needed}" == "true" ]] || [[ "${kubernetes_tests_needed}" == "true" ]]; then
+ : ${compile_needed:=false}
Review Comment:
I am not sure I follow this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3396: HDDS-6719. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3396:
URL: https://github.com/apache/ozone/pull/3396#discussion_r868954913
##########
dev-support/ci/selective_ci_checks.sh:
##########
@@ -521,12 +521,14 @@ function set_outputs() {
initialization::ga_output basic-checks \
"$(initialization::parameters_to_json ${BASIC_CHECKS})"
- if [[ "${compose_tests_needed}" == "true" ]] || [[ "${kubernetes_tests_needed}" == "true" ]]; then
+ : ${compile_needed:=false}
Review Comment:
`: ${compile_needed:=false}`
This assigns default value `false` to the variable `compile_needed`. If the variable is already set, this is a no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3396: HDDS-6719. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3396:
URL: https://github.com/apache/ozone/pull/3396#discussion_r868956488
##########
dev-support/ci/selective_ci_checks.bats:
##########
@@ -121,7 +121,7 @@ load bats-assert/load.bash
run dev-support/ci/selective_ci_checks.sh 1dd1d0ba3
assert_output -p 'basic-checks=["rat","author","checkstyle","findbugs","unit"]'
- assert_output -p needs-build=false
+ assert_output -p needs-build=true
Review Comment:
Unit testing is not affected, only compile check. Increase is minimal (the time to create the tarball). Overall wall-clock time of CI workflow does not increase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #3396: HDDS-6719. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3396:
URL: https://github.com/apache/ozone/pull/3396#discussion_r868563540
##########
dev-support/ci/selective_ci_checks.bats:
##########
@@ -121,7 +121,7 @@ load bats-assert/load.bash
run dev-support/ci/selective_ci_checks.sh 1dd1d0ba3
assert_output -p 'basic-checks=["rat","author","checkstyle","findbugs","unit"]'
- assert_output -p needs-build=false
+ assert_output -p needs-build=true
Review Comment:
Would the move to source tar ball build increase the unit testing time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3396: HDDS-6719. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3396:
URL: https://github.com/apache/ozone/pull/3396#issuecomment-1136342279
Thanks @kerneltime and @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3396: HDDS-6719. Verify build from source release tarball in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3396:
URL: https://github.com/apache/ozone/pull/3396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org