You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2016/12/10 19:19:17 UTC

Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50457/
-----------------------------------------------------------

(Updated Dec. 10, 2016, 7:19 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5902
    https://issues.apache.org/jira/browse/MESOS-5902


Repository: mesos


Description (updated)
-------

Added a cmake library that makes use of configure_file to transform
a source file at a relative location to the Source directory in to a
target file at a realtive location into the Build Directory.
The transformation replaces any CMake Variables in the source with
assigned values.


Diffs (updated)
-----

  cmake/Common.cmake 76b2a67419cb6836b598a0070f26632d4ca048ff 
  src/java/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/50457/diff/


Testing
-------

cmake .. 
Check to see if <BUILD_DIR>/src/java/generated/org/apache/mesos/MesosNativeLibrary.java is generated.


Thanks,

Srinivas Brahmaroutu


Re: Review Request 50457: Added code to generate MesosNativeLibrary.java.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50457/#review167515
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.

- Joris Van Remoortere


On Dec. 10, 2016, 7:19 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50457/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
>     https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a cmake library that makes use of configure_file to transform
> a source file at a relative location to the Source directory in to a
> target file at a realtive location into the Build Directory.
> The transformation replaces any CMake Variables in the source with
> assigned values.
> 
> 
> Diffs
> -----
> 
>   cmake/Common.cmake 76b2a67419cb6836b598a0070f26632d4ca048ff 
>   src/java/CMakeLists.txt PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/50457/diff/5/
> 
> 
> Testing
> -------
> 
> cmake .. 
> Check to see if <BUILD_DIR>/src/java/generated/org/apache/mesos/MesosNativeLibrary.java is generated.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>