You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Brian Rowe (JIRA)" <ji...@apache.org> on 2017/06/28 21:02:00 UTC

[jira] [Created] (GEODE-3149) Protobuf protocol module will throw exceptions on some input

Brian Rowe created GEODE-3149:
---------------------------------

             Summary: Protobuf protocol module will throw exceptions on some input
                 Key: GEODE-3149
                 URL: https://issues.apache.org/jira/browse/GEODE-3149
             Project: Geode
          Issue Type: Bug
            Reporter: Brian Rowe


The protobuf protocol handler needs to be able to handle any input on the incoming socket without crashing.  

Right now closing the socket will cause a crash as we try to process a message from the empty stream (the bug here might be that the server connection shouldn't be trying to process a message here, but the protocol deserialization still needs to have much better error handling).

{code:java}
severe 2017/06/28 13:50:55.565 PDT <ServerConnection on port 22514 Thread 0> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 Thread 0,5,ServerConnection on port 22514]
java.lang.NullPointerException
	at org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
	at org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
	at org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
	at org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
	at java.lang.Thread.run(Thread.java:748)
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)