You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/01 04:59:06 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request #522: fix: CI path filter
tao12345666333 opened a new pull request #522:
URL: https://github.com/apache/apisix-ingress-controller/pull/522
Signed-off-by: Jintao Zhang <zh...@gmail.com>
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
fix CI path filter logics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #522: fix: CI path filter
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #522:
URL: https://github.com/apache/apisix-ingress-controller/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #522: fix: CI path filter
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #522:
URL: https://github.com/apache/apisix-ingress-controller/pull/522#discussion_r642801161
##########
File path: .github/workflows/golangci-lint.yml
##########
@@ -44,11 +45,21 @@ jobs:
filters: |
docs:
- 'docs/**/*'
+ - '*.md'
+ go:
+ - '**/*.go'
Review comment:
Yep. Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #522: fix: CI path filter
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #522:
URL: https://github.com/apache/apisix-ingress-controller/pull/522#discussion_r642791597
##########
File path: .github/workflows/golangci-lint.yml
##########
@@ -44,11 +45,21 @@ jobs:
filters: |
docs:
- 'docs/**/*'
+ - '*.md'
+ go:
+ - '**/*.go'
Review comment:
Shoud also add `tools.go` and `main.go`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org