You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "labbomb (via GitHub)" <gi...@apache.org> on 2023/10/15 04:35:47 UTC

[PR] [Feature] add login models and api demo [incubator-paimon-webui]

labbomb opened a new pull request, #53:
URL: https://github.com/apache/incubator-paimon-webui/pull/53

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- What is the purpose of the change, or the associated issue -->
   Added examples of api usage
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature] add login models and api demo [incubator-paimon-webui]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #53:
URL: https://github.com/apache/incubator-paimon-webui/pull/53#discussion_r1359984966


##########
paimon-web-ui-new/src/views/playground/components/slider/index.tsx:
##########
@@ -35,14 +35,14 @@ export default defineComponent({
       workspaceList: [
         {
           icon: renderIcon(Layers),
-          title: 'Layers',
+          title: 'query',
           description: computed(() => (t('playground.query'))),
           isClick: true,
           path: '/playground/query'
         },
         {
           icon: renderIcon(CodeSlashSharp),
-          title: 'Code',
+          title: 'workbench',

Review Comment:
   ```suggestion
             title: 'Workbench',
   ```



##########
paimon-web-ui-new/src/views/playground/components/slider/index.tsx:
##########
@@ -35,14 +35,14 @@ export default defineComponent({
       workspaceList: [
         {
           icon: renderIcon(Layers),
-          title: 'Layers',
+          title: 'query',

Review Comment:
   ```suggestion
             title: 'Query',
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature] add login models and api demo [incubator-paimon-webui]

Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #53:
URL: https://github.com/apache/incubator-paimon-webui/pull/53


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org