You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hadoop.apache.org by Viraj Jasani <vj...@apache.org> on 2021/09/11 18:58:26 UTC
[DISCUSS] Checkin Hadoop code formatter
+ common-dev@hadoop.apache.org
---------- Forwarded message ---------
From: Viraj Jasani <vj...@apache.org>
Date: Tue, Sep 7, 2021 at 6:18 PM
Subject: Checkin Hadoop code formatter
To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
It seems some recent new devs are not familiar with the common code
formatter that we use for our codebase.
While we already have Wiki page [1] for new contributors and it mentions:
"Code must be formatted according to Sun's conventions
<http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html>"
but this Oracle's code conventions page is not being actively maintained
(no update has been received after 1999) and hence, I believe we should
check-in and maintain code formatter xmls for supported IDEs in our
codebase only (under dev-support) for all devs to be able to import it in
the respective IDE.
Keeping this in mind, I have created this PR 3387
<https://github.com/apache/hadoop/pull/3387>. If you could please take a
look and if the PR receives sufficient +1s, we might want to update our
Wiki page to directly refer to our own codebase for code formatters that we
maintain. Thoughts?
1.
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Takanobu Asanuma <ta...@apache.org>.
Thanks for the initiative, Viraj.
I agree to add the code formatter.
- Takanobu
2021年9月12日(日) 5:01 Ayush Saxena <ay...@gmail.com>:
> Thanx Viraj for initiating, Makes sense to me to include a formmater
> inline with our checkstyle rules in the code, would make life simpler for
> all devs.
>
> -Ayush
>
> > On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
> >
> > + common-dev@hadoop.apache.org
> >
> > ---------- Forwarded message ---------
> > From: Viraj Jasani <vj...@apache.org>
> > Date: Tue, Sep 7, 2021 at 6:18 PM
> > Subject: Checkin Hadoop code formatter
> > To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
> >
> >
> > It seems some recent new devs are not familiar with the common code
> > formatter that we use for our codebase.
> > While we already have Wiki page [1] for new contributors and it mentions:
> > "Code must be formatted according to Sun's conventions
> > <
> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
> >"
> > but this Oracle's code conventions page is not being actively maintained
> > (no update has been received after 1999) and hence, I believe we should
> > check-in and maintain code formatter xmls for supported IDEs in our
> > codebase only (under dev-support) for all devs to be able to import it in
> > the respective IDE.
> > Keeping this in mind, I have created this PR 3387
> > <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> > look and if the PR receives sufficient +1s, we might want to update our
> > Wiki page to directly refer to our own codebase for code formatters that
> we
> > maintain. Thoughts?
> >
> >
> > 1.
> >
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Takanobu Asanuma <ta...@apache.org>.
Thanks for the initiative, Viraj.
I agree to add the code formatter.
- Takanobu
2021年9月12日(日) 5:01 Ayush Saxena <ay...@gmail.com>:
> Thanx Viraj for initiating, Makes sense to me to include a formmater
> inline with our checkstyle rules in the code, would make life simpler for
> all devs.
>
> -Ayush
>
> > On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
> >
> > + common-dev@hadoop.apache.org
> >
> > ---------- Forwarded message ---------
> > From: Viraj Jasani <vj...@apache.org>
> > Date: Tue, Sep 7, 2021 at 6:18 PM
> > Subject: Checkin Hadoop code formatter
> > To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
> >
> >
> > It seems some recent new devs are not familiar with the common code
> > formatter that we use for our codebase.
> > While we already have Wiki page [1] for new contributors and it mentions:
> > "Code must be formatted according to Sun's conventions
> > <
> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
> >"
> > but this Oracle's code conventions page is not being actively maintained
> > (no update has been received after 1999) and hence, I believe we should
> > check-in and maintain code formatter xmls for supported IDEs in our
> > codebase only (under dev-support) for all devs to be able to import it in
> > the respective IDE.
> > Keeping this in mind, I have created this PR 3387
> > <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> > look and if the PR receives sufficient +1s, we might want to update our
> > Wiki page to directly refer to our own codebase for code formatters that
> we
> > maintain. Thoughts?
> >
> >
> > 1.
> >
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Takanobu Asanuma <ta...@apache.org>.
Thanks for the initiative, Viraj.
I agree to add the code formatter.
- Takanobu
2021年9月12日(日) 5:01 Ayush Saxena <ay...@gmail.com>:
> Thanx Viraj for initiating, Makes sense to me to include a formmater
> inline with our checkstyle rules in the code, would make life simpler for
> all devs.
>
> -Ayush
>
> > On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
> >
> > + common-dev@hadoop.apache.org
> >
> > ---------- Forwarded message ---------
> > From: Viraj Jasani <vj...@apache.org>
> > Date: Tue, Sep 7, 2021 at 6:18 PM
> > Subject: Checkin Hadoop code formatter
> > To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
> >
> >
> > It seems some recent new devs are not familiar with the common code
> > formatter that we use for our codebase.
> > While we already have Wiki page [1] for new contributors and it mentions:
> > "Code must be formatted according to Sun's conventions
> > <
> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
> >"
> > but this Oracle's code conventions page is not being actively maintained
> > (no update has been received after 1999) and hence, I believe we should
> > check-in and maintain code formatter xmls for supported IDEs in our
> > codebase only (under dev-support) for all devs to be able to import it in
> > the respective IDE.
> > Keeping this in mind, I have created this PR 3387
> > <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> > look and if the PR receives sufficient +1s, we might want to update our
> > Wiki page to directly refer to our own codebase for code formatters that
> we
> > maintain. Thoughts?
> >
> >
> > 1.
> >
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Takanobu Asanuma <ta...@apache.org>.
Thanks for the initiative, Viraj.
I agree to add the code formatter.
- Takanobu
2021年9月12日(日) 5:01 Ayush Saxena <ay...@gmail.com>:
> Thanx Viraj for initiating, Makes sense to me to include a formmater
> inline with our checkstyle rules in the code, would make life simpler for
> all devs.
>
> -Ayush
>
> > On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
> >
> > + common-dev@hadoop.apache.org
> >
> > ---------- Forwarded message ---------
> > From: Viraj Jasani <vj...@apache.org>
> > Date: Tue, Sep 7, 2021 at 6:18 PM
> > Subject: Checkin Hadoop code formatter
> > To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
> >
> >
> > It seems some recent new devs are not familiar with the common code
> > formatter that we use for our codebase.
> > While we already have Wiki page [1] for new contributors and it mentions:
> > "Code must be formatted according to Sun's conventions
> > <
> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
> >"
> > but this Oracle's code conventions page is not being actively maintained
> > (no update has been received after 1999) and hence, I believe we should
> > check-in and maintain code formatter xmls for supported IDEs in our
> > codebase only (under dev-support) for all devs to be able to import it in
> > the respective IDE.
> > Keeping this in mind, I have created this PR 3387
> > <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> > look and if the PR receives sufficient +1s, we might want to update our
> > Wiki page to directly refer to our own codebase for code formatters that
> we
> > maintain. Thoughts?
> >
> >
> > 1.
> >
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Takanobu Asanuma <ta...@apache.org>.
Thanks for the initiative, Viraj.
I agree to add the code formatter.
- Takanobu
2021年9月12日(日) 5:01 Ayush Saxena <ay...@gmail.com>:
> Thanx Viraj for initiating, Makes sense to me to include a formmater
> inline with our checkstyle rules in the code, would make life simpler for
> all devs.
>
> -Ayush
>
> > On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
> >
> > + common-dev@hadoop.apache.org
> >
> > ---------- Forwarded message ---------
> > From: Viraj Jasani <vj...@apache.org>
> > Date: Tue, Sep 7, 2021 at 6:18 PM
> > Subject: Checkin Hadoop code formatter
> > To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
> >
> >
> > It seems some recent new devs are not familiar with the common code
> > formatter that we use for our codebase.
> > While we already have Wiki page [1] for new contributors and it mentions:
> > "Code must be formatted according to Sun's conventions
> > <
> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
> >"
> > but this Oracle's code conventions page is not being actively maintained
> > (no update has been received after 1999) and hence, I believe we should
> > check-in and maintain code formatter xmls for supported IDEs in our
> > codebase only (under dev-support) for all devs to be able to import it in
> > the respective IDE.
> > Keeping this in mind, I have created this PR 3387
> > <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> > look and if the PR receives sufficient +1s, we might want to update our
> > Wiki page to directly refer to our own codebase for code formatters that
> we
> > maintain. Thoughts?
> >
> >
> > 1.
> >
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Ayush Saxena <ay...@gmail.com>.
Thanx Viraj for initiating, Makes sense to me to include a formmater inline with our checkstyle rules in the code, would make life simpler for all devs.
-Ayush
> On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
>
> + common-dev@hadoop.apache.org
>
> ---------- Forwarded message ---------
> From: Viraj Jasani <vj...@apache.org>
> Date: Tue, Sep 7, 2021 at 6:18 PM
> Subject: Checkin Hadoop code formatter
> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>
>
> It seems some recent new devs are not familiar with the common code
> formatter that we use for our codebase.
> While we already have Wiki page [1] for new contributors and it mentions:
> "Code must be formatted according to Sun's conventions
> <http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html>"
> but this Oracle's code conventions page is not being actively maintained
> (no update has been received after 1999) and hence, I believe we should
> check-in and maintain code formatter xmls for supported IDEs in our
> codebase only (under dev-support) for all devs to be able to import it in
> the respective IDE.
> Keeping this in mind, I have created this PR 3387
> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> look and if the PR receives sufficient +1s, we might want to update our
> Wiki page to directly refer to our own codebase for code formatters that we
> maintain. Thoughts?
>
>
> 1.
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-help@hadoop.apache.org
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Ayush Saxena <ay...@gmail.com>.
Thanx Viraj for initiating, Makes sense to me to include a formmater inline with our checkstyle rules in the code, would make life simpler for all devs.
-Ayush
> On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
>
> + common-dev@hadoop.apache.org
>
> ---------- Forwarded message ---------
> From: Viraj Jasani <vj...@apache.org>
> Date: Tue, Sep 7, 2021 at 6:18 PM
> Subject: Checkin Hadoop code formatter
> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>
>
> It seems some recent new devs are not familiar with the common code
> formatter that we use for our codebase.
> While we already have Wiki page [1] for new contributors and it mentions:
> "Code must be formatted according to Sun's conventions
> <http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html>"
> but this Oracle's code conventions page is not being actively maintained
> (no update has been received after 1999) and hence, I believe we should
> check-in and maintain code formatter xmls for supported IDEs in our
> codebase only (under dev-support) for all devs to be able to import it in
> the respective IDE.
> Keeping this in mind, I have created this PR 3387
> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> look and if the PR receives sufficient +1s, we might want to update our
> Wiki page to directly refer to our own codebase for code formatters that we
> maintain. Thoughts?
>
>
> 1.
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Ayush Saxena <ay...@gmail.com>.
Thanx Viraj for initiating, Makes sense to me to include a formmater inline with our checkstyle rules in the code, would make life simpler for all devs.
-Ayush
> On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
>
> + common-dev@hadoop.apache.org
>
> ---------- Forwarded message ---------
> From: Viraj Jasani <vj...@apache.org>
> Date: Tue, Sep 7, 2021 at 6:18 PM
> Subject: Checkin Hadoop code formatter
> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>
>
> It seems some recent new devs are not familiar with the common code
> formatter that we use for our codebase.
> While we already have Wiki page [1] for new contributors and it mentions:
> "Code must be formatted according to Sun's conventions
> <http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html>"
> but this Oracle's code conventions page is not being actively maintained
> (no update has been received after 1999) and hence, I believe we should
> check-in and maintain code formatter xmls for supported IDEs in our
> codebase only (under dev-support) for all devs to be able to import it in
> the respective IDE.
> Keeping this in mind, I have created this PR 3387
> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> look and if the PR receives sufficient +1s, we might want to update our
> Wiki page to directly refer to our own codebase for code formatters that we
> maintain. Thoughts?
>
>
> 1.
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Ayush Saxena <ay...@gmail.com>.
Thanx Viraj for initiating, Makes sense to me to include a formmater inline with our checkstyle rules in the code, would make life simpler for all devs.
-Ayush
> On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
>
> + common-dev@hadoop.apache.org
>
> ---------- Forwarded message ---------
> From: Viraj Jasani <vj...@apache.org>
> Date: Tue, Sep 7, 2021 at 6:18 PM
> Subject: Checkin Hadoop code formatter
> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>
>
> It seems some recent new devs are not familiar with the common code
> formatter that we use for our codebase.
> While we already have Wiki page [1] for new contributors and it mentions:
> "Code must be formatted according to Sun's conventions
> <http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html>"
> but this Oracle's code conventions page is not being actively maintained
> (no update has been received after 1999) and hence, I believe we should
> check-in and maintain code formatter xmls for supported IDEs in our
> codebase only (under dev-support) for all devs to be able to import it in
> the respective IDE.
> Keeping this in mind, I have created this PR 3387
> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> look and if the PR receives sufficient +1s, we might want to update our
> Wiki page to directly refer to our own codebase for code formatters that we
> maintain. Thoughts?
>
>
> 1.
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Ayush Saxena <ay...@gmail.com>.
Thanx Viraj for initiating, Makes sense to me to include a formmater inline with our checkstyle rules in the code, would make life simpler for all devs.
-Ayush
> On 12-Sep-2021, at 12:28 AM, Viraj Jasani <vj...@apache.org> wrote:
>
> + common-dev@hadoop.apache.org
>
> ---------- Forwarded message ---------
> From: Viraj Jasani <vj...@apache.org>
> Date: Tue, Sep 7, 2021 at 6:18 PM
> Subject: Checkin Hadoop code formatter
> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>
>
> It seems some recent new devs are not familiar with the common code
> formatter that we use for our codebase.
> While we already have Wiki page [1] for new contributors and it mentions:
> "Code must be formatted according to Sun's conventions
> <http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html>"
> but this Oracle's code conventions page is not being actively maintained
> (no update has been received after 1999) and hence, I believe we should
> check-in and maintain code formatter xmls for supported IDEs in our
> codebase only (under dev-support) for all devs to be able to import it in
> the respective IDE.
> Keeping this in mind, I have created this PR 3387
> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> look and if the PR receives sufficient +1s, we might want to update our
> Wiki page to directly refer to our own codebase for code formatters that we
> maintain. Thoughts?
>
>
> 1.
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: dev-help@hadoop.apache.org
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Viraj Jasani <vj...@apache.org>.
PR 3387 <https://github.com/apache/hadoop/pull/3387> has been merged and
the Wiki page is also updated for devs to refer to the IDEA code formatter
xml. If any Eclipse user would like to contribute the formatter xml, please
feel free to comment on HADOOP-17892
<https://issues.apache.org/jira/browse/HADOOP-17892> or create a sub-task.
Thanks to everyone who helped with reviews, merging the PR and updating the
Wiki page.
On Tue, Sep 14, 2021 at 5:29 PM Hui Fei <fe...@gmail.com> wrote:
> Thanks Viraj.
> It does make sense.
>
> Viraj Jasani <vj...@apache.org> 于2021年9月12日周日 上午2:58写道：
>
>> + common-dev@hadoop.apache.org
>>
>> ---------- Forwarded message ---------
>> From: Viraj Jasani <vj...@apache.org>
>> Date: Tue, Sep 7, 2021 at 6:18 PM
>> Subject: Checkin Hadoop code formatter
>> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>>
>>
>> It seems some recent new devs are not familiar with the common code
>> formatter that we use for our codebase.
>> While we already have Wiki page [1] for new contributors and it mentions:
>> "Code must be formatted according to Sun's conventions
>> <
>> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
>> >"
>> but this Oracle's code conventions page is not being actively maintained
>> (no update has been received after 1999) and hence, I believe we should
>> check-in and maintain code formatter xmls for supported IDEs in our
>> codebase only (under dev-support) for all devs to be able to import it in
>> the respective IDE.
>> Keeping this in mind, I have created this PR 3387
>> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
>> look and if the PR receives sufficient +1s, we might want to update our
>> Wiki page to directly refer to our own codebase for code formatters that
>> we
>> maintain. Thoughts?
>>
>>
>> 1.
>>
>> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Viraj Jasani <vj...@apache.org>.
PR 3387 <https://github.com/apache/hadoop/pull/3387> has been merged and
the Wiki page is also updated for devs to refer to the IDEA code formatter
xml. If any Eclipse user would like to contribute the formatter xml, please
feel free to comment on HADOOP-17892
<https://issues.apache.org/jira/browse/HADOOP-17892> or create a sub-task.
Thanks to everyone who helped with reviews, merging the PR and updating the
Wiki page.
On Tue, Sep 14, 2021 at 5:29 PM Hui Fei <fe...@gmail.com> wrote:
> Thanks Viraj.
> It does make sense.
>
> Viraj Jasani <vj...@apache.org> 于2021年9月12日周日 上午2:58写道：
>
>> + common-dev@hadoop.apache.org
>>
>> ---------- Forwarded message ---------
>> From: Viraj Jasani <vj...@apache.org>
>> Date: Tue, Sep 7, 2021 at 6:18 PM
>> Subject: Checkin Hadoop code formatter
>> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>>
>>
>> It seems some recent new devs are not familiar with the common code
>> formatter that we use for our codebase.
>> While we already have Wiki page [1] for new contributors and it mentions:
>> "Code must be formatted according to Sun's conventions
>> <
>> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
>> >"
>> but this Oracle's code conventions page is not being actively maintained
>> (no update has been received after 1999) and hence, I believe we should
>> check-in and maintain code formatter xmls for supported IDEs in our
>> codebase only (under dev-support) for all devs to be able to import it in
>> the respective IDE.
>> Keeping this in mind, I have created this PR 3387
>> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
>> look and if the PR receives sufficient +1s, we might want to update our
>> Wiki page to directly refer to our own codebase for code formatters that
>> we
>> maintain. Thoughts?
>>
>>
>> 1.
>>
>> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Viraj Jasani <vj...@apache.org>.
PR 3387 <https://github.com/apache/hadoop/pull/3387> has been merged and
the Wiki page is also updated for devs to refer to the IDEA code formatter
xml. If any Eclipse user would like to contribute the formatter xml, please
feel free to comment on HADOOP-17892
<https://issues.apache.org/jira/browse/HADOOP-17892> or create a sub-task.
Thanks to everyone who helped with reviews, merging the PR and updating the
Wiki page.
On Tue, Sep 14, 2021 at 5:29 PM Hui Fei <fe...@gmail.com> wrote:
> Thanks Viraj.
> It does make sense.
>
> Viraj Jasani <vj...@apache.org> 于2021年9月12日周日 上午2:58写道：
>
>> + common-dev@hadoop.apache.org
>>
>> ---------- Forwarded message ---------
>> From: Viraj Jasani <vj...@apache.org>
>> Date: Tue, Sep 7, 2021 at 6:18 PM
>> Subject: Checkin Hadoop code formatter
>> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>>
>>
>> It seems some recent new devs are not familiar with the common code
>> formatter that we use for our codebase.
>> While we already have Wiki page [1] for new contributors and it mentions:
>> "Code must be formatted according to Sun's conventions
>> <
>> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
>> >"
>> but this Oracle's code conventions page is not being actively maintained
>> (no update has been received after 1999) and hence, I believe we should
>> check-in and maintain code formatter xmls for supported IDEs in our
>> codebase only (under dev-support) for all devs to be able to import it in
>> the respective IDE.
>> Keeping this in mind, I have created this PR 3387
>> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
>> look and if the PR receives sufficient +1s, we might want to update our
>> Wiki page to directly refer to our own codebase for code formatters that
>> we
>> maintain. Thoughts?
>>
>>
>> 1.
>>
>> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Viraj Jasani <vj...@apache.org>.
PR 3387 <https://github.com/apache/hadoop/pull/3387> has been merged and
the Wiki page is also updated for devs to refer to the IDEA code formatter
xml. If any Eclipse user would like to contribute the formatter xml, please
feel free to comment on HADOOP-17892
<https://issues.apache.org/jira/browse/HADOOP-17892> or create a sub-task.
Thanks to everyone who helped with reviews, merging the PR and updating the
Wiki page.
On Tue, Sep 14, 2021 at 5:29 PM Hui Fei <fe...@gmail.com> wrote:
> Thanks Viraj.
> It does make sense.
>
> Viraj Jasani <vj...@apache.org> 于2021年9月12日周日 上午2:58写道：
>
>> + common-dev@hadoop.apache.org
>>
>> ---------- Forwarded message ---------
>> From: Viraj Jasani <vj...@apache.org>
>> Date: Tue, Sep 7, 2021 at 6:18 PM
>> Subject: Checkin Hadoop code formatter
>> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>>
>>
>> It seems some recent new devs are not familiar with the common code
>> formatter that we use for our codebase.
>> While we already have Wiki page [1] for new contributors and it mentions:
>> "Code must be formatted according to Sun's conventions
>> <
>> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
>> >"
>> but this Oracle's code conventions page is not being actively maintained
>> (no update has been received after 1999) and hence, I believe we should
>> check-in and maintain code formatter xmls for supported IDEs in our
>> codebase only (under dev-support) for all devs to be able to import it in
>> the respective IDE.
>> Keeping this in mind, I have created this PR 3387
>> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
>> look and if the PR receives sufficient +1s, we might want to update our
>> Wiki page to directly refer to our own codebase for code formatters that
>> we
>> maintain. Thoughts?
>>
>>
>> 1.
>>
>> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Viraj Jasani <vj...@apache.org>.
PR 3387 <https://github.com/apache/hadoop/pull/3387> has been merged and
the Wiki page is also updated for devs to refer to the IDEA code formatter
xml. If any Eclipse user would like to contribute the formatter xml, please
feel free to comment on HADOOP-17892
<https://issues.apache.org/jira/browse/HADOOP-17892> or create a sub-task.
Thanks to everyone who helped with reviews, merging the PR and updating the
Wiki page.
On Tue, Sep 14, 2021 at 5:29 PM Hui Fei <fe...@gmail.com> wrote:
> Thanks Viraj.
> It does make sense.
>
> Viraj Jasani <vj...@apache.org> 于2021年9月12日周日 上午2:58写道：
>
>> + common-dev@hadoop.apache.org
>>
>> ---------- Forwarded message ---------
>> From: Viraj Jasani <vj...@apache.org>
>> Date: Tue, Sep 7, 2021 at 6:18 PM
>> Subject: Checkin Hadoop code formatter
>> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>>
>>
>> It seems some recent new devs are not familiar with the common code
>> formatter that we use for our codebase.
>> While we already have Wiki page [1] for new contributors and it mentions:
>> "Code must be formatted according to Sun's conventions
>> <
>> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
>> >"
>> but this Oracle's code conventions page is not being actively maintained
>> (no update has been received after 1999) and hence, I believe we should
>> check-in and maintain code formatter xmls for supported IDEs in our
>> codebase only (under dev-support) for all devs to be able to import it in
>> the respective IDE.
>> Keeping this in mind, I have created this PR 3387
>> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
>> look and if the PR receives sufficient +1s, we might want to update our
>> Wiki page to directly refer to our own codebase for code formatters that
>> we
>> maintain. Thoughts?
>>
>>
>> 1.
>>
>> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>>
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Hui Fei <fe...@gmail.com>.
Thanks Viraj.
It does make sense.
Viraj Jasani <vj...@apache.org> 于2021年9月12日周日 上午2:58写道：
> + common-dev@hadoop.apache.org
>
> ---------- Forwarded message ---------
> From: Viraj Jasani <vj...@apache.org>
> Date: Tue, Sep 7, 2021 at 6:18 PM
> Subject: Checkin Hadoop code formatter
> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>
>
> It seems some recent new devs are not familiar with the common code
> formatter that we use for our codebase.
> While we already have Wiki page [1] for new contributors and it mentions:
> "Code must be formatted according to Sun's conventions
> <
> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
> >"
> but this Oracle's code conventions page is not being actively maintained
> (no update has been received after 1999) and hence, I believe we should
> check-in and maintain code formatter xmls for supported IDEs in our
> codebase only (under dev-support) for all devs to be able to import it in
> the respective IDE.
> Keeping this in mind, I have created this PR 3387
> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> look and if the PR receives sufficient +1s, we might want to update our
> Wiki page to directly refer to our own codebase for code formatters that we
> maintain. Thoughts?
>
>
> 1.
>
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>
Re: [DISCUSS] Checkin Hadoop code formatter
Posted by Hui Fei <fe...@gmail.com>.
Thanks Viraj.
It does make sense.
Viraj Jasani <vj...@apache.org> 于2021年9月12日周日 上午2:58写道：
> + common-dev@hadoop.apache.org
>
> ---------- Forwarded message ---------
> From: Viraj Jasani <vj...@apache.org>
> Date: Tue, Sep 7, 2021 at 6:18 PM
> Subject: Checkin Hadoop code formatter
> To: common-dev@hadoop.apache.org <de...@hadoop.apache.org>
>
>
> It seems some recent new devs are not familiar with the common code
> formatter that we use for our codebase.
> While we already have Wiki page [1] for new contributors and it mentions:
> "Code must be formatted according to Sun's conventions
> <
> http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html
> >"
> but this Oracle's code conventions page is not being actively maintained
> (no update has been received after 1999) and hence, I believe we should
> check-in and maintain code formatter xmls for supported IDEs in our
> codebase only (under dev-support) for all devs to be able to import it in
> the respective IDE.
> Keeping this in mind, I have created this PR 3387
> <https://github.com/apache/hadoop/pull/3387>. If you could please take a
> look and if the PR receives sufficient +1s, we might want to update our
> Wiki page to directly refer to our own codebase for code formatters that we
> maintain. Thoughts?
>
>
> 1.
>
> https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute#HowToContribute-MakingChanges
>