You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/04/28 17:48:11 UTC
Review Request 46786: Add missing Mesos dependency to packer build
script.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Stephan Erb.
Repository: aurora
Description
-------
See http://markmail.org/message/rofuiaclgkesfx3o for full details.
Diffs
-----
build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
Diff: https://reviews.apache.org/r/46786/diff/
Testing
-------
Successfully built base box with these changes.
Thanks,
Joshua Cohen
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by John Sirois <js...@apache.org>.
> On April 28, 2016, 10:02 a.m., John Sirois wrote:
> > build-support/packer/build.sh, line 44
> > <https://reviews.apache.org/r/46786/diff/1/?file=1364773#file1364773line44>
> >
> > I'm missing how this is needed too.
>
> Joshua Cohen wrote:
> If I remove this we don't have a jdk in the vagrant image and therefore can't build the scheduler. I.e., I guess default-jre-headless brings in only the JRE but not the JDK?
>
> John Sirois wrote:
> Backing up - were you anticipating the mesos upgrade issue linked or did you hit a different real issue that prompted this change? If the former, JDKs include JREs in their jre subdir and the fact we have a direct dependency on a jdk means no upgrade will magically remove it.
>
> John Sirois wrote:
> TLDR; the mesos thread could be said to be warning for all non-JRE-using frameworks only.
>
> Joshua Cohen wrote:
> I'm trying to build a new base box in another branch for the unified container changes and it was failing on the `install_mesos` step due to java-runtime-headless not being found. After ruling out my changes by running the script on master and getting the same results, I happened across that thread on mesos-users that described the problem. I'll confess to being unfamiliar with the internals of all this packaging.
>
> You should be able to replicate the original problem fairly trivially by running the packer build command on master. If there's a better/cleaner solution than adding this dependency (or getting mesosphere to publish a new deb), I'm open to it!
>
> John Sirois wrote:
> I think 1 dep on https://launchpad.net/ubuntu/+source/openjdk-8 with a note why - ie we need its transitive dep on jdk for aurora builds + jre for mesos deb package constraints.
> Or else - preferrable I think for being explicit - the existing dep on openjdk-8-jdk-headless paired with a dep on openjdk-8-jre-headless and a comment on why the latter. The mesos thread comment could be removed since its not at play here fwict - ie we are not worried about magic removal, just trying to satisfy a deb logical dep fwict.
>
> These take me a while on my slow link, but I'm trying this out now.
This works for me:
```diff
$ git diff -U1
diff --git a/build-support/packer/build.sh b/build-support/packer/build.sh
index 658dbc4..57279c8 100644
--- a/build-support/packer/build.sh
+++ b/build-support/packer/build.sh
@@ -19,3 +19,3 @@ set -o verbose
-readonly MESOS_VERSION=0.27.2
+readonly MESOS_VERSION=0.28.0
@@ -29,3 +29,3 @@ function remove_unused {
function install_base_packages {
- add-apt-repository ppa:openjdk-r/ppa -y
+ add-apt-repository -y ppa:openjdk-r/ppa
apt-get update
@@ -40,3 +40,3 @@ function install_base_packages {
libsvn-dev \
- openjdk-8-jdk \
+ openjdk-8-jdk-headless \
python-dev
@@ -44,3 +44,3 @@ function install_base_packages {
# Installing zookeeperd as a separate command, as otherwise openjdk-7-jdk is also installed.
- apt-get install -y zookeeperd
+ apt-get -y install zookeeperd
}
@@ -49,3 +49,3 @@ function install_docker {
# Instructions from https://docs.docker.com/engine/installation/linux/ubuntulinux/
- apt-get install -y apt-transport-https ca-certificates
+ apt-get -y install apt-transport-https ca-certificates
apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 \
@@ -62,8 +62,9 @@ function install_docker {
function install_mesos {
- URL_BASE='http://repos.mesosphere.com/ubuntu/pool/main/m/mesos'
- DEB_URL="$URL_BASE/mesos_${MESOS_VERSION}-2.0.15.ubuntu1404_amd64.deb"
- deb=$(basename $DEB_URL)
- wget -c "$DEB_URL"
- dpkg --install $deb
- rm $deb
+ sudo apt-key adv --keyserver keyserver.ubuntu.com --recv E56151BF
+ DISTRO=$(lsb_release -is | tr '[:upper:]' '[:lower:]')
+ CODENAME=$(lsb_release -cs)
+ echo "deb http://repos.mesosphere.io/${DISTRO} ${CODENAME} main" \
+ > /etc/apt/sources.list.d/mesosphere.list
+ apt-get update
+ apt-get -y install mesos=${MESOS_VERSION}*
}
@@ -77,3 +78,3 @@ function install_thrift {
apt-get update
- apt-get install thrift-compiler=0.9.1
+ apt-get -y install thrift-compiler=0.9.1
}
```
The jdk is slimmed to headless, no explicit jre added - and the lynchpin is the use of apt-get to install mesos.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130929
-----------------------------------------------------------
On April 28, 2016, 11:08 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 11:08 a.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by John Sirois <js...@apache.org>.
> On April 28, 2016, 10:02 a.m., John Sirois wrote:
> > build-support/packer/build.sh, line 44
> > <https://reviews.apache.org/r/46786/diff/1/?file=1364773#file1364773line44>
> >
> > I'm missing how this is needed too.
>
> Joshua Cohen wrote:
> If I remove this we don't have a jdk in the vagrant image and therefore can't build the scheduler. I.e., I guess default-jre-headless brings in only the JRE but not the JDK?
Backing up - were you anticipating the mesos upgrade issue linked or did you hit a different real issue that prompted this change? If the former, JDKs include JREs in their jre subdir and the fact we have a direct dependency on a jdk means no upgrade will magically remove it.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130929
-----------------------------------------------------------
On April 28, 2016, 11:08 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 11:08 a.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Joshua Cohen <jc...@apache.org>.
> On April 28, 2016, 4:02 p.m., John Sirois wrote:
> > build-support/packer/build.sh, line 37
> > <https://reviews.apache.org/r/46786/diff/1/?file=1364773#file1364773line37>
> >
> > Try default-jre-headless?: https://launchpad.net/ubuntu/trusty/+package/default-jre-headless
Looks like default-jre-headless will work.
> On April 28, 2016, 4:02 p.m., John Sirois wrote:
> > build-support/packer/build.sh, line 44
> > <https://reviews.apache.org/r/46786/diff/1/?file=1364773#file1364773line44>
> >
> > I'm missing how this is needed too.
If I remove this we don't have a jdk in the vagrant image and therefore can't build the scheduler. I.e., I guess default-jre-headless brings in only the JRE but not the JDK?
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130929
-----------------------------------------------------------
On April 28, 2016, 3:48 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 3:48 p.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by John Sirois <js...@apache.org>.
> On April 28, 2016, 10:02 a.m., John Sirois wrote:
> > build-support/packer/build.sh, line 44
> > <https://reviews.apache.org/r/46786/diff/1/?file=1364773#file1364773line44>
> >
> > I'm missing how this is needed too.
>
> Joshua Cohen wrote:
> If I remove this we don't have a jdk in the vagrant image and therefore can't build the scheduler. I.e., I guess default-jre-headless brings in only the JRE but not the JDK?
>
> John Sirois wrote:
> Backing up - were you anticipating the mesos upgrade issue linked or did you hit a different real issue that prompted this change? If the former, JDKs include JREs in their jre subdir and the fact we have a direct dependency on a jdk means no upgrade will magically remove it.
TLDR; the mesos thread could be said to be warning for all non-JRE-using frameworks only.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130929
-----------------------------------------------------------
On April 28, 2016, 11:08 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 11:08 a.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Joshua Cohen <jc...@apache.org>.
> On April 28, 2016, 4:02 p.m., John Sirois wrote:
> > build-support/packer/build.sh, line 44
> > <https://reviews.apache.org/r/46786/diff/1/?file=1364773#file1364773line44>
> >
> > I'm missing how this is needed too.
>
> Joshua Cohen wrote:
> If I remove this we don't have a jdk in the vagrant image and therefore can't build the scheduler. I.e., I guess default-jre-headless brings in only the JRE but not the JDK?
>
> John Sirois wrote:
> Backing up - were you anticipating the mesos upgrade issue linked or did you hit a different real issue that prompted this change? If the former, JDKs include JREs in their jre subdir and the fact we have a direct dependency on a jdk means no upgrade will magically remove it.
>
> John Sirois wrote:
> TLDR; the mesos thread could be said to be warning for all non-JRE-using frameworks only.
I'm trying to build a new base box in another branch for the unified container changes and it was failing on the `install_mesos` step due to java-runtime-headless not being found. After ruling out my changes by running the script on master and getting the same results, I happened across that thread on mesos-users that described the problem. I'll confess to being unfamiliar with the internals of all this packaging.
You should be able to replicate the original problem fairly trivially by running the packer build command on master. If there's a better/cleaner solution than adding this dependency (or getting mesosphere to publish a new deb), I'm open to it!
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130929
-----------------------------------------------------------
On April 28, 2016, 5:08 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 5:08 p.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by John Sirois <js...@apache.org>.
> On April 28, 2016, 10:02 a.m., John Sirois wrote:
> > build-support/packer/build.sh, line 44
> > <https://reviews.apache.org/r/46786/diff/1/?file=1364773#file1364773line44>
> >
> > I'm missing how this is needed too.
>
> Joshua Cohen wrote:
> If I remove this we don't have a jdk in the vagrant image and therefore can't build the scheduler. I.e., I guess default-jre-headless brings in only the JRE but not the JDK?
>
> John Sirois wrote:
> Backing up - were you anticipating the mesos upgrade issue linked or did you hit a different real issue that prompted this change? If the former, JDKs include JREs in their jre subdir and the fact we have a direct dependency on a jdk means no upgrade will magically remove it.
>
> John Sirois wrote:
> TLDR; the mesos thread could be said to be warning for all non-JRE-using frameworks only.
>
> Joshua Cohen wrote:
> I'm trying to build a new base box in another branch for the unified container changes and it was failing on the `install_mesos` step due to java-runtime-headless not being found. After ruling out my changes by running the script on master and getting the same results, I happened across that thread on mesos-users that described the problem. I'll confess to being unfamiliar with the internals of all this packaging.
>
> You should be able to replicate the original problem fairly trivially by running the packer build command on master. If there's a better/cleaner solution than adding this dependency (or getting mesosphere to publish a new deb), I'm open to it!
I think 1 dep on https://launchpad.net/ubuntu/+source/openjdk-8 with a note why - ie we need its transitive dep on jdk for aurora builds + jre for mesos deb package constraints.
Or else - preferrable I think for being explicit - the existing dep on openjdk-8-jdk-headless paired with a dep on openjdk-8-jre-headless and a comment on why the latter. The mesos thread comment could be removed since its not at play here fwict - ie we are not worried about magic removal, just trying to satisfy a deb logical dep fwict.
These take me a while on my slow link, but I'm trying this out now.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130929
-----------------------------------------------------------
On April 28, 2016, 11:08 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 11:08 a.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130929
-----------------------------------------------------------
build-support/packer/build.sh (line 37)
<https://reviews.apache.org/r/46786/#comment194833>
Try default-jre-headless?: https://launchpad.net/ubuntu/trusty/+package/default-jre-headless
build-support/packer/build.sh (line 44)
<https://reviews.apache.org/r/46786/#comment194834>
I'm missing how this is needed too.
- John Sirois
On April 28, 2016, 9:48 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 9:48 a.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130980
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On April 28, 2016, 1:37 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 1:37 p.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes and then ran e2e tests.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/
-----------------------------------------------------------
(Updated April 28, 2016, 7:37 p.m.)
Review request for Aurora, John Sirois and Stephan Erb.
Changes
-------
Update based on John's diff.
Repository: aurora
Description
-------
See http://markmail.org/message/rofuiaclgkesfx3o for full details.
Diffs (updated)
-----
build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
Diff: https://reviews.apache.org/r/46786/diff/
Testing (updated)
-------
Successfully built base box with these changes and then ran e2e tests.
Thanks,
Joshua Cohen
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130948
-----------------------------------------------------------
Ship it!
Master (e817eb1) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 28, 2016, 5:08 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 5:08 p.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/
-----------------------------------------------------------
(Updated April 28, 2016, 5:08 p.m.)
Review request for Aurora, John Sirois and Stephan Erb.
Changes
-------
Switch to default-jre-headless
Repository: aurora
Description
-------
See http://markmail.org/message/rofuiaclgkesfx3o for full details.
Diffs (updated)
-----
build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
Diff: https://reviews.apache.org/r/46786/diff/
Testing
-------
Successfully built base box with these changes.
Thanks,
Joshua Cohen
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130923
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On April 28, 2016, 5:48 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 5:48 p.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Joshua Cohen <jc...@apache.org>.
> On April 28, 2016, 3:54 p.m., Maxim Khutornenko wrote:
> > build-support/packer/build.sh, line 37
> > <https://reviews.apache.org/r/46786/diff/1/?file=1364773#file1364773line37>
> >
> > What about the `java2-runtime-headless` proposed in that pull request? Did you find it redundant?
I found that java2-runtime-headless did not work at all:
...
virtualbox-ovf: Package java2-runtime-headless is a virtual package provided by:
virtualbox-ovf: openjdk-8-jre-headless 8u91-b14-0ubuntu4~14.04
virtualbox-ovf: openjdk-6-jre-headless 6b38-1.13.10-0ubuntu0.14.04.1
virtualbox-ovf: openjdk-7-jre-headless 7u95-2.6.4-0ubuntu0.14.04.2
virtualbox-ovf: gcj-4.8-jre-headless 4.8.4-2ubuntu1~14.04.1
virtualbox-ovf: gcj-jre-headless 4:4.8.2-1ubuntu6
virtualbox-ovf: default-jre-headless 2:1.7-51
virtualbox-ovf:
virtualbox-ovf: E: Package 'java2-runtime-headless' has no installation candidate
==> virtualbox-ovf: Unregistering and deleting imported VM...
==> virtualbox-ovf: Deleting output directory...
Build 'virtualbox-ovf' errored: Script exited with non-zero exit status: 100
But perhaps I missed something?
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130924
-----------------------------------------------------------
On April 28, 2016, 3:48 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 3:48 p.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130924
-----------------------------------------------------------
build-support/packer/build.sh (line 37)
<https://reviews.apache.org/r/46786/#comment194830>
What about the `java2-runtime-headless` proposed in that pull request? Did you find it redundant?
- Maxim Khutornenko
On April 28, 2016, 3:48 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 3:48 p.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 46786: Add missing Mesos dependency to packer build
script.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46786/#review130930
-----------------------------------------------------------
Ship it!
Master (e817eb1) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 28, 2016, 3:48 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46786/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 3:48 p.m.)
>
>
> Review request for Aurora, John Sirois and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> See http://markmail.org/message/rofuiaclgkesfx3o for full details.
>
>
> Diffs
> -----
>
> build-support/packer/build.sh 658dbc4bc5ae0dd1cfa69abd8fdf6119c3ccf8c9
>
> Diff: https://reviews.apache.org/r/46786/diff/
>
>
> Testing
> -------
>
> Successfully built base box with these changes.
>
>
> Thanks,
>
> Joshua Cohen
>
>